iproute2-3.6.0 assumes presence of iptables

iproute2-3.6.0 assumes presence of iptables

[Matt Burgess]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi,

When compiling iproute2-3.6.0 on a host that doesn't have iptables available, I get the following error:

gcc -Wall -Wstrict-prototypes -O2 -I../include -DRESOLVE_HOSTNAMES
-DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE
-DCONFIG_GACT -DCONFIG_GACT_PROB -DYY_NO_INPUT   -c -o em_ipset.o
em_ipset.c
em_ipset.c:26:21: fatal error: xtables.h: No such file or directory

Fixed by the following patch, which guards the building of em_ipset.o on
the presence of suitable headers.

Thanks,

Matt.

[-- Attachment #2: iproute2-3.6.0-ipset-1.patch --]
[-- Type: text/x-patch, Size: 398 bytes --]

diff -Naur iproute2-3.6.0.orig/tc/Makefile iproute2-3.6.0/tc/Makefile
--- iproute2-3.6.0.orig/tc/Makefile	2012-10-01 15:39:21.000000000 +0000
+++ iproute2-3.6.0/tc/Makefile	2012-10-02 17:45:31.605612832 +0000
@@ -52,7 +52,9 @@
 TCMODULES += q_fq_codel.o
 
 ifeq ($(TC_CONFIG_IPSET), y)
-  TCMODULES += em_ipset.o
+  ifeq ($(TC_CONFIG_XT), y)
+    TCMODULES += em_ipset.o
+  endif
 endif
 
 TCSO :=

Re: iproute2-3.6.0 assumes presence of iptables

[Stephen Hemminger]

On Tue, 02 Oct 2012 19:01:32 +0100
Matt Burgess <matthew@linuxfromscratch.org> wrote:

> Hi,
> 
> When compiling iproute2-3.6.0 on a host that doesn't have iptables available, I get the following error:
> 
> gcc -Wall -Wstrict-prototypes -O2 -I../include -DRESOLVE_HOSTNAMES
> -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE
> -DCONFIG_GACT -DCONFIG_GACT_PROB -DYY_NO_INPUT   -c -o em_ipset.o
> em_ipset.c
> em_ipset.c:26:21: fatal error: xtables.h: No such file or directory
> 
> Fixed by the following patch, which guards the building of em_ipset.o on
> the presence of suitable headers.
> 
> Thanks,
> 
> Matt.

Applied