* [PATCH net-next] virtio_net: use net_*_ratelimited() helpers
@ 2012-11-09 3:47 Cong Wang
2012-11-09 22:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2012-11-09 3:47 UTC (permalink / raw)
To: netdev; +Cc: Rusty Russell, Michael S. Tsirkin, David Miller, Cong Wang
These can be converted to net_*_ratelimited().
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index cbf8b06..26c502e 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -212,8 +212,7 @@ static struct sk_buff *page_to_skb(struct virtnet_info *vi,
* the case of a broken device.
*/
if (unlikely(len > MAX_SKB_FRAGS * PAGE_SIZE)) {
- if (net_ratelimit())
- pr_debug("%s: too much data\n", skb->dev->name);
+ net_dbg_ratelimited("%s: too much data\n", skb->dev->name);
dev_kfree_skb(skb);
return NULL;
}
@@ -333,9 +332,8 @@ static void receive_buf(struct net_device *dev, void *buf, unsigned int len)
skb_shinfo(skb)->gso_type = SKB_GSO_TCPV6;
break;
default:
- if (net_ratelimit())
- printk(KERN_WARNING "%s: bad gso type %u.\n",
- dev->name, hdr->hdr.gso_type);
+ net_warn_ratelimited("%s: bad gso type %u.\n",
+ dev->name, hdr->hdr.gso_type);
goto frame_err;
}
@@ -344,9 +342,7 @@ static void receive_buf(struct net_device *dev, void *buf, unsigned int len)
skb_shinfo(skb)->gso_size = hdr->hdr.gso_size;
if (skb_shinfo(skb)->gso_size == 0) {
- if (net_ratelimit())
- printk(KERN_WARNING "%s: zero gso size.\n",
- dev->name);
+ net_warn_ratelimited("%s: zero gso size.\n", dev->name);
goto frame_err;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] virtio_net: use net_*_ratelimited() helpers
2012-11-09 3:47 [PATCH net-next] virtio_net: use net_*_ratelimited() helpers Cong Wang
@ 2012-11-09 22:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-11-09 22:05 UTC (permalink / raw)
To: amwang; +Cc: netdev, rusty, mst
From: Cong Wang <amwang@redhat.com>
Date: Fri, 9 Nov 2012 11:47:28 +0800
> These can be converted to net_*_ratelimited().
>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: David Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-09 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-09 3:47 [PATCH net-next] virtio_net: use net_*_ratelimited() helpers Cong Wang
2012-11-09 22:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).