netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] ipv4: fib: fix a comment.
@ 2013-01-11 19:59 Rami Rosen
  2013-01-11 23:59 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2013-01-11 19:59 UTC (permalink / raw)
  To: davem; +Cc: netdev, Rami Rosen

In fib_frontend.c, there is a confusing comment; NETLINK_CB(skb).portid does not 
refer to a pid of sending process, but rather to a netlink portid.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 net/ipv4/fib_frontend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index 5cd75e2..99f00d3 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -974,7 +974,7 @@ static void nl_fib_input(struct sk_buff *skb)
 
 	nl_fib_lookup(frn, tb);
 
-	portid = NETLINK_CB(skb).portid;      /* pid of sending process */
+	portid = NETLINK_CB(skb).portid;      /* netlink portid */
 	NETLINK_CB(skb).portid = 0;        /* from kernel */
 	NETLINK_CB(skb).dst_group = 0;  /* unicast */
 	netlink_unicast(net->ipv4.fibnl, skb, portid, MSG_DONTWAIT);
-- 
1.7.11.7

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] ipv4: fib: fix a comment.
  2013-01-11 19:59 [PATCH net-next] ipv4: fib: fix a comment Rami Rosen
@ 2013-01-11 23:59 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-01-11 23:59 UTC (permalink / raw)
  To: ramirose; +Cc: netdev

From: Rami Rosen <ramirose@gmail.com>
Date: Fri, 11 Jan 2013 21:59:20 +0200

> In fib_frontend.c, there is a confusing comment; NETLINK_CB(skb).portid does not 
> refer to a pid of sending process, but rather to a netlink portid.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-01-11 23:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-11 19:59 [PATCH net-next] ipv4: fib: fix a comment Rami Rosen
2013-01-11 23:59 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).