netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: bjorn@mork.no, netdev@vger.kernel.org, dlstevens@us.ibm.com,
	stephen@networkplumber.org
Subject: Re: [Patch net-next v7 4/6] vxlan: add ipv6 support
Date: Tue, 30 Apr 2013 15:05:47 -0400 (EDT)	[thread overview]
Message-ID: <20130430.150547.2297961494334074636.davem@davemloft.net> (raw)
In-Reply-To: <1367313956.3216.18.camel@cr0>

From: Cong Wang <amwang@redhat.com>
Date: Tue, 30 Apr 2013 17:25:56 +0800

> On Tue, 2013-04-30 at 11:17 +0200, Bjørn Mork wrote:
>> Please take your time to clean up your todo-list and *test* the result
>> with different runtime and buildtime settings. There is no need to rush
>> this, and people may get tired of looking at the same shortcomings over
>> and over again.
>> 
> 
> So, why do you expect it is perfect?

Your patch has had large, major, shortcomings every single iteration.

It isn't ready yet, and now that the net-next tree is closed, you have
time to work on the patch series slowly, and carefully, instead of
trying to rush things and making several mistakes.

  parent reply	other threads:[~2013-04-30 19:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30  8:43 [Patch net-next v7 0/6] vxlan: add ipv6 support Cong Wang
2013-04-30  8:43 ` [Patch net-next v7 1/6] vxlan: defer vxlan init as late as possible Cong Wang
2013-04-30  8:43 ` [Patch net-next v7 2/6] ipv6: export a stub for ipv6_sock_mc_join and ipv6_sock_mc_drop Cong Wang
2013-04-30  8:43 ` [Patch net-next v7 3/6] ipv6: export in6addr_loopback to modules Cong Wang
2013-04-30  8:43 ` [Patch net-next v7 4/6] vxlan: add ipv6 support Cong Wang
2013-04-30  9:17   ` Bjørn Mork
2013-04-30  9:25     ` Cong Wang
2013-04-30 10:33       ` Bjørn Mork
2013-04-30 19:06         ` David Miller
2013-05-02  8:05         ` Cong Wang
2013-05-02  8:10           ` David Miller
2013-05-02 12:45           ` Bjørn Mork
2013-05-03  3:02             ` Cong Wang
2013-04-30 19:05       ` David Miller [this message]
2013-05-02  7:55         ` Cong Wang
2013-04-30  9:38     ` Cong Wang
2013-04-30 18:58       ` David Miller
2013-04-30 19:04     ` David Miller
2013-04-30  8:43 ` [Patch net-next v7 5/6] vxlan: respect disable_ipv6 sysctl Cong Wang
2013-04-30 12:27   ` Sergei Shtylyov
2013-04-30  8:43 ` [Patch net-next v7 6/6] ipv6: Add generic UDP Tunnel segmentation Cong Wang
2013-04-30 19:00 ` [Patch net-next v7 0/6] vxlan: add ipv6 support David Miller
2013-05-02  7:02   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130430.150547.2297961494334074636.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amwang@redhat.com \
    --cc=bjorn@mork.no \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).