From: "Bjørn Mork" <bjorn@mork.no>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, David Stevens <dlstevens@us.ibm.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next v7 4/6] vxlan: add ipv6 support
Date: Thu, 02 May 2013 14:45:36 +0200 [thread overview]
Message-ID: <87sj25a6tr.fsf@nemi.mork.no> (raw)
In-Reply-To: <1367481953.2415.29.camel@cr0> (Cong Wang's message of "Thu, 02 May 2013 16:05:53 +0800")
Cong Wang <amwang@redhat.com> writes:
> On Tue, 2013-04-30 at 12:33 +0200, Bjørn Mork wrote:
>>
>> Well, you have been told that your proposed new feature breaks IPv4
>> support with specific settings. I do not think that you are speeding
>> up
>> anything here by ignoring that fact. On the contrary.
>
> It is obviously a corner case which is not deserved such a high priority
> (as high as a kernel panic or a compile error). bindv6only is default to
> be 0, I even wasn't aware of such sysctl until David pointed it out.
It's a regression. Regressions trump new features. No need to argue
about the relative importance here. Fix it.
> So, please give me a reason why we should let such a corner case block
> the inclusion? I think there are still other such corner cases too (and
> maybe many), which neither you nor me are aware of.
Yes, I am pretty sure of that as well. That's why I ask you to *test*
your code with assorted settings before resubmitting it. I'm not going
to.
I note that you claim you are not an expert. Neither am I. And luckily
I believe that is not required around here. Anyone can contribute, and
all contributions are very welcome. At least that is the impression
I've got.
But only the experts can get away with limited testing. The less of an
expert you are, the more time you need to spend trying out every small
codepath you added using every possible input combination. Doing
different combinations of buildtime and runtime IPv6 enable/disable is
an obvious requirement when you add code which has some sort of "if IPv6
is enabled" conditionals. IMHO.
Bjørn
next prev parent reply other threads:[~2013-05-02 12:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 8:43 [Patch net-next v7 0/6] vxlan: add ipv6 support Cong Wang
2013-04-30 8:43 ` [Patch net-next v7 1/6] vxlan: defer vxlan init as late as possible Cong Wang
2013-04-30 8:43 ` [Patch net-next v7 2/6] ipv6: export a stub for ipv6_sock_mc_join and ipv6_sock_mc_drop Cong Wang
2013-04-30 8:43 ` [Patch net-next v7 3/6] ipv6: export in6addr_loopback to modules Cong Wang
2013-04-30 8:43 ` [Patch net-next v7 4/6] vxlan: add ipv6 support Cong Wang
2013-04-30 9:17 ` Bjørn Mork
2013-04-30 9:25 ` Cong Wang
2013-04-30 10:33 ` Bjørn Mork
2013-04-30 19:06 ` David Miller
2013-05-02 8:05 ` Cong Wang
2013-05-02 8:10 ` David Miller
2013-05-02 12:45 ` Bjørn Mork [this message]
2013-05-03 3:02 ` Cong Wang
2013-04-30 19:05 ` David Miller
2013-05-02 7:55 ` Cong Wang
2013-04-30 9:38 ` Cong Wang
2013-04-30 18:58 ` David Miller
2013-04-30 19:04 ` David Miller
2013-04-30 8:43 ` [Patch net-next v7 5/6] vxlan: respect disable_ipv6 sysctl Cong Wang
2013-04-30 12:27 ` Sergei Shtylyov
2013-04-30 8:43 ` [Patch net-next v7 6/6] ipv6: Add generic UDP Tunnel segmentation Cong Wang
2013-04-30 19:00 ` [Patch net-next v7 0/6] vxlan: add ipv6 support David Miller
2013-05-02 7:02 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj25a6tr.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).