* [PATCH net-next] filter: fix va_list build error
@ 2013-05-01 20:24 Xi Wang
2013-05-01 20:29 ` David Miller
2013-05-01 21:04 ` Daniel Borkmann
0 siblings, 2 replies; 4+ messages in thread
From: Xi Wang @ 2013-05-01 20:24 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Xi Wang
This patch fixes the following build error.
In file included from include/linux/filter.h:52:0,
from arch/arm/net/bpf_jit_32.c:14:
include/linux/printk.h:54:2: error: unknown type name ‘va_list’
include/linux/printk.h:105:21: error: unknown type name ‘va_list’
include/linux/printk.h:108:30: error: unknown type name ‘va_list’
Signed-off-by: Xi Wang <xi.wang@gmail.com>
---
include/linux/filter.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/filter.h b/include/linux/filter.h
index d1248f4..c050dcc 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -48,6 +48,7 @@ extern int sk_chk_filter(struct sock_filter *filter, unsigned int flen);
extern int sk_get_filter(struct sock *sk, struct sock_filter __user *filter, unsigned len);
#ifdef CONFIG_BPF_JIT
+#include <stdarg.h>
#include <linux/linkage.h>
#include <linux/printk.h>
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] filter: fix va_list build error
2013-05-01 20:24 [PATCH net-next] filter: fix va_list build error Xi Wang
@ 2013-05-01 20:29 ` David Miller
2013-05-01 21:04 ` Daniel Borkmann
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2013-05-01 20:29 UTC (permalink / raw)
To: xi.wang; +Cc: netdev
From: Xi Wang <xi.wang@gmail.com>
Date: Wed, 1 May 2013 16:24:08 -0400
> This patch fixes the following build error.
>
> In file included from include/linux/filter.h:52:0,
> from arch/arm/net/bpf_jit_32.c:14:
> include/linux/printk.h:54:2: error: unknown type name ‘va_list’
> include/linux/printk.h:105:21: error: unknown type name ‘va_list’
> include/linux/printk.h:108:30: error: unknown type name ‘va_list’
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] filter: fix va_list build error
2013-05-01 20:24 [PATCH net-next] filter: fix va_list build error Xi Wang
2013-05-01 20:29 ` David Miller
@ 2013-05-01 21:04 ` Daniel Borkmann
2013-05-01 22:29 ` Xi Wang
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2013-05-01 21:04 UTC (permalink / raw)
To: Xi Wang; +Cc: David S. Miller, netdev
On 05/01/2013 10:24 PM, Xi Wang wrote:
> This patch fixes the following build error.
>
> In file included from include/linux/filter.h:52:0,
> from arch/arm/net/bpf_jit_32.c:14:
> include/linux/printk.h:54:2: error: unknown type name ‘va_list’
> include/linux/printk.h:105:21: error: unknown type name ‘va_list’
> include/linux/printk.h:108:30: error: unknown type name ‘va_list’
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
> ---
> include/linux/filter.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index d1248f4..c050dcc 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -48,6 +48,7 @@ extern int sk_chk_filter(struct sock_filter *filter, unsigned int flen);
> extern int sk_get_filter(struct sock *sk, struct sock_filter __user *filter, unsigned len);
>
> #ifdef CONFIG_BPF_JIT
> +#include <stdarg.h>
> #include <linux/linkage.h>
> #include <linux/printk.h>
That's a bit weird. Xi, maybe in a follow-up some time later, could
you move the GCC-internal stdarg.h rather into linux/printk.h, since
that's where the problem is coming from? Imho, it might be better off
there, no?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] filter: fix va_list build error
2013-05-01 21:04 ` Daniel Borkmann
@ 2013-05-01 22:29 ` Xi Wang
0 siblings, 0 replies; 4+ messages in thread
From: Xi Wang @ 2013-05-01 22:29 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: David S. Miller, netdev, Joe Perches
On Wed, May 1, 2013 at 5:04 PM, Daniel Borkmann <dborkman@redhat.com> wrote:
> That's a bit weird. Xi, maybe in a follow-up some time later, could
> you move the GCC-internal stdarg.h rather into linux/printk.h, since
> that's where the problem is coming from? Imho, it might be better off
> there, no?
There was some discussion a while ago on whether to make printk.h self
contained or to disallow including it directly. Joe Perches [CCed]
had patches for that.
https://lkml.org/lkml/2011/5/25/263
- xi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-01 22:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-01 20:24 [PATCH net-next] filter: fix va_list build error Xi Wang
2013-05-01 20:29 ` David Miller
2013-05-01 21:04 ` Daniel Borkmann
2013-05-01 22:29 ` Xi Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).