* [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload
@ 2013-05-02 21:10 Sergei Shtylyov
[not found] ` <CAP8WD_ZYxhjYag3dQSKnbB6JojV=jxZzmn7_kJW_eOzQOWtKTg@mail.gmail.com>
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2013-05-02 21:10 UTC (permalink / raw)
To: netdev, klassert, tedheadster
When unloading the driver that drives an EISA board, a message similar to the
following one is displayed:
Trying to free nonexistent resource <0000000000013000-000000000001301f>
Then an user is unable to reload the driver because the resource it requested in
the previous load hasn't been freed. This happens most probably due to a typo in
vortex_eisa_remove() which calls release_region() with 'dev->base_addr' instead
of 'edev->base_addr'...
Reported-by: Matthew Whitehead <tedheadster@gmail.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against David Miller's 'net-next.git' repo.
Matthew, please test it and report on the list.
drivers/net/ethernet/3com/3c59x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: net-next/drivers/net/ethernet/3com/3c59x.c
===================================================================
--- net-next.orig/drivers/net/ethernet/3com/3c59x.c
+++ net-next/drivers/net/ethernet/3com/3c59x.c
@@ -951,7 +951,7 @@ static int vortex_eisa_remove(struct dev
unregister_netdev(dev);
iowrite16(TotalReset|0x14, ioaddr + EL3_CMD);
- release_region(dev->base_addr, VORTEX_TOTAL_SIZE);
+ release_region(edev->base_addr, VORTEX_TOTAL_SIZE);
free_netdev(dev);
return 0;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload
[not found] ` <CAP8WD_ZYxhjYag3dQSKnbB6JojV=jxZzmn7_kJW_eOzQOWtKTg@mail.gmail.com>
@ 2013-05-04 18:12 ` Sergei Shtylyov
0 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2013-05-04 18:12 UTC (permalink / raw)
To: whiteheadm; +Cc: tedheadster, netdev, klassert
Hello.
On 03-05-2013 8:26, tedheadster wrote:
> Sergei
> well, the patch got rid of the "Trying to free nonexistent resource" error.
> However, a problem still persists.
Does the module at least loads OK for the EISA card now?
> When reloading the module a second time, the system's responsiveness hangs for
> 10s of seconds. It eventually comes back, but even sysrq-h hangs for a long
> time. I was able to do a sysrq-t eventually and capture the output to a log.
> What shall we do to debug this next?
Frankly speaking, I don't know, and don't have much time to invest in this...
> - Matthew
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload
2013-05-02 21:10 [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload Sergei Shtylyov
[not found] ` <CAP8WD_ZYxhjYag3dQSKnbB6JojV=jxZzmn7_kJW_eOzQOWtKTg@mail.gmail.com>
@ 2013-05-04 22:07 ` Sergei Shtylyov
2013-05-06 16:22 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2013-05-04 22:07 UTC (permalink / raw)
To: netdev, klassert, tedheadster, David Miller
Hello.
On 05/03/2013 01:10 AM, Sergei Shtylyov wrote:
> When unloading the driver that drives an EISA board, a message similar to the
> following one is displayed:
>
> Trying to free nonexistent resource <0000000000013000-000000000001301f>
>
> Then an user is unable to reload the driver because the resource it requested in
> the previous load hasn't been freed. This happens most probably due to a typo in
> vortex_eisa_remove() which calls release_region() with 'dev->base_addr' instead
> of 'edev->base_addr'...
>
> Reported-by: Matthew Whitehead <tedheadster@gmail.com>
Should I repost this now with [RFT] removed and this line changed to:
Reported-and-tested-by: Matthew Whitehead <tedheadster@gmail.com>
or could you do it when/if applying, David?
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload
2013-05-02 21:10 [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload Sergei Shtylyov
[not found] ` <CAP8WD_ZYxhjYag3dQSKnbB6JojV=jxZzmn7_kJW_eOzQOWtKTg@mail.gmail.com>
2013-05-04 22:07 ` Sergei Shtylyov
@ 2013-05-06 16:22 ` David Miller
2013-05-06 20:45 ` Sergei Shtylyov
2 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2013-05-06 16:22 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, klassert, tedheadster
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 3 May 2013 01:10:22 +0400
> When unloading the driver that drives an EISA board, a message similar to the
> following one is displayed:
>
> Trying to free nonexistent resource <0000000000013000-000000000001301f>
>
> Then an user is unable to reload the driver because the resource it requested in
> the previous load hasn't been freed. This happens most probably due to a typo in
> vortex_eisa_remove() which calls release_region() with 'dev->base_addr' instead
> of 'edev->base_addr'...
>
> Reported-by: Matthew Whitehead <tedheadster@gmail.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload
2013-05-06 16:22 ` David Miller
@ 2013-05-06 20:45 ` Sergei Shtylyov
2013-05-06 20:50 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2013-05-06 20:45 UTC (permalink / raw)
To: David Miller; +Cc: netdev, klassert, tedheadster
On 05/06/2013 08:22 PM, David Miller wrote:
>
>> When unloading the driver that drives an EISA board, a message similar to the
>> following one is displayed:
>>
>> Trying to free nonexistent resource <0000000000013000-000000000001301f>
>>
>> Then an user is unable to reload the driver because the resource it requested in
>> the previous load hasn't been freed. This happens most probably due to a typo in
>> vortex_eisa_remove() which calls release_region() with 'dev->base_addr' instead
>> of 'edev->base_addr'...
>>
>> Reported-by: Matthew Whitehead <tedheadster@gmail.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied, thanks.
Will you queue this patch for stable?
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload
2013-05-06 20:45 ` Sergei Shtylyov
@ 2013-05-06 20:50 ` David Miller
2013-05-06 21:49 ` Sergei Shtylyov
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2013-05-06 20:50 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, klassert, tedheadster
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Tue, 07 May 2013 00:45:30 +0400
> Will you queue this patch for stable?
Done.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload
2013-05-06 20:50 ` David Miller
@ 2013-05-06 21:49 ` Sergei Shtylyov
0 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2013-05-06 21:49 UTC (permalink / raw)
To: David Miller; +Cc: netdev, klassert, tedheadster
On 05/07/2013 12:50 AM, David Miller wrote:
>
>> Will you queue this patch for stable?
> Done.
Thank you. It's really ancient error, though for the ancient boards
only as well...
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-05-06 21:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-02 21:10 [PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload Sergei Shtylyov
[not found] ` <CAP8WD_ZYxhjYag3dQSKnbB6JojV=jxZzmn7_kJW_eOzQOWtKTg@mail.gmail.com>
2013-05-04 18:12 ` Sergei Shtylyov
2013-05-04 22:07 ` Sergei Shtylyov
2013-05-06 16:22 ` David Miller
2013-05-06 20:45 ` Sergei Shtylyov
2013-05-06 20:50 ` David Miller
2013-05-06 21:49 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).