* [Patch net] xfrm6: release dev before returning error
@ 2013-05-10 8:40 Cong Wang
2013-05-12 0:41 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2013-05-10 8:40 UTC (permalink / raw)
To: netdev; +Cc: Herbert Xu, Steffen Klassert, David S. Miller, Cong Wang
From: Cong Wang <amwang@redhat.com>
We forget to call dev_put() on error path in xfrm6_fill_dst(),
its caller doesn't handle this.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
index 4ef7bdb..23ed03d 100644
--- a/net/ipv6/xfrm6_policy.c
+++ b/net/ipv6/xfrm6_policy.c
@@ -103,8 +103,10 @@ static int xfrm6_fill_dst(struct xfrm_dst *xdst, struct net_device *dev,
dev_hold(dev);
xdst->u.rt6.rt6i_idev = in6_dev_get(dev);
- if (!xdst->u.rt6.rt6i_idev)
+ if (!xdst->u.rt6.rt6i_idev) {
+ dev_put(dev);
return -ENODEV;
+ }
rt6_transfer_peer(&xdst->u.rt6, rt);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch net] xfrm6: release dev before returning error
2013-05-10 8:40 [Patch net] xfrm6: release dev before returning error Cong Wang
@ 2013-05-12 0:41 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-12 0:41 UTC (permalink / raw)
To: amwang; +Cc: netdev, herbert, steffen.klassert
From: Cong Wang <amwang@redhat.com>
Date: Fri, 10 May 2013 16:40:00 +0800
> From: Cong Wang <amwang@redhat.com>
>
> We forget to call dev_put() on error path in xfrm6_fill_dst(),
> its caller doesn't handle this.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-12 0:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-10 8:40 [Patch net] xfrm6: release dev before returning error Cong Wang
2013-05-12 0:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).