[PATCH net-next] doc:networking: Update comment for dev_id field in netdevice.h

[PATCH net-next] doc:networking: Update comment for dev_id field in netdevice.h

[Narendra_K]

This patch updates the comment for 'dev_id' field in
'include/linux/netdevice.h' to reflect the intended
usage of 'dev_id'.

References: http://marc.info/?l=linux-netdev&m=136992115300526&w=2
References: http://marc.info/?l=linux-netdev&m=137062569014612&w=2

Signed-off-by: Narendra K <narendra_k@dell.com>
---
 include/linux/netdevice.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 8f967e3..a43712e 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1142,8 +1142,10 @@ struct net_device {
 	unsigned char		addr_assign_type; /* hw address assignment type */
 	unsigned char		addr_len;	/* hardware address length	*/
 	unsigned char		neigh_priv_len;
-	unsigned short          dev_id;		/* for shared network cards */
-
+	unsigned short          dev_id;		/* Used to differentiate devices
+						 * that share the same link
+						 * layer address
+						 */
 	spinlock_t		addr_list_lock;
 	struct netdev_hw_addr_list	uc;	/* Unicast mac addresses */
 	struct netdev_hw_addr_list	mc;	/* Multicast mac addresses */
-- 
1.8.0.1

-- 
With regards,
Narendra K
Linux Engineering
Dell Inc.

Re: [PATCH net-next] doc:networking: Update comment for dev_id field in netdevice.h

[Ben Hutchings]

On Mon, 2013-06-10 at 19:34 +0530, Narendra_K@Dell.com wrote:
> This patch updates the comment for 'dev_id' field in
> 'include/linux/netdevice.h' to reflect the intended
> usage of 'dev_id'.
> 
> References: http://marc.info/?l=linux-netdev&m=136992115300526&w=2
> References: http://marc.info/?l=linux-netdev&m=137062569014612&w=2
> 
> Signed-off-by: Narendra K <narendra_k@dell.com>

Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>

> ---
>  include/linux/netdevice.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 8f967e3..a43712e 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1142,8 +1142,10 @@ struct net_device {
>  	unsigned char		addr_assign_type; /* hw address assignment type */
>  	unsigned char		addr_len;	/* hardware address length	*/
>  	unsigned char		neigh_priv_len;
> -	unsigned short          dev_id;		/* for shared network cards */
> -
> +	unsigned short          dev_id;		/* Used to differentiate devices
> +						 * that share the same link
> +						 * layer address
> +						 */
>  	spinlock_t		addr_list_lock;
>  	struct netdev_hw_addr_list	uc;	/* Unicast mac addresses */
>  	struct netdev_hw_addr_list	mc;	/* Multicast mac addresses */
> -- 
> 1.8.0.1
> 

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: [PATCH net-next] doc:networking: Update comment for dev_id field in netdevice.h

[David Miller]

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 10 Jun 2013 17:11:10 +0100

> On Mon, 2013-06-10 at 19:34 +0530, Narendra_K@Dell.com wrote:
>> This patch updates the comment for 'dev_id' field in
>> 'include/linux/netdevice.h' to reflect the intended
>> usage of 'dev_id'.
>> 
>> References: http://marc.info/?l=linux-netdev&m=136992115300526&w=2
>> References: http://marc.info/?l=linux-netdev&m=137062569014612&w=2
>> 
>> Signed-off-by: Narendra K <narendra_k@dell.com>
> 
> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>

Applied, thanks.