netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit
@ 2013-07-09  8:36 Jongsung Kim
  2013-07-09 16:02 ` Nicolas Ferre
  0 siblings, 1 reply; 3+ messages in thread
From: Jongsung Kim @ 2013-07-09  8:36 UTC (permalink / raw)
  To: nicolas.ferre, davem; +Cc: netdev, linux-kernel, stable, Jongsung Kim

Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
---
 drivers/net/ethernet/cadence/macb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index c89aa41..b4e0dc8 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1070,7 +1070,7 @@ static void macb_configure_dma(struct macb *bp)
 static void macb_configure_caps(struct macb *bp)
 {
 	if (macb_is_gem(bp)) {
-		if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
+		if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
 			bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
 	}
 }
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit
  2013-07-09  8:36 [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit Jongsung Kim
@ 2013-07-09 16:02 ` Nicolas Ferre
  2013-07-09 19:50   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Ferre @ 2013-07-09 16:02 UTC (permalink / raw)
  To: Jongsung Kim, davem, netdev; +Cc: linux-kernel, stable

On 09/07/2013 10:36, Jongsung Kim :
> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: stable <stable@vger.kernel.org> # 3.10+

Thanks for having spotted that.

Best regards,

> ---
>   drivers/net/ethernet/cadence/macb.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index c89aa41..b4e0dc8 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1070,7 +1070,7 @@ static void macb_configure_dma(struct macb *bp)
>   static void macb_configure_caps(struct macb *bp)
>   {
>   	if (macb_is_gem(bp)) {
> -		if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
> +		if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
>   			bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
>   	}
>   }
>


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit
  2013-07-09 16:02 ` Nicolas Ferre
@ 2013-07-09 19:50   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-07-09 19:50 UTC (permalink / raw)
  To: nicolas.ferre; +Cc: neidhard.kim, netdev, linux-kernel, stable

From: Nicolas Ferre <nicolas.ferre@atmel.com>
Date: Tue, 9 Jul 2013 18:02:23 +0200

> On 09/07/2013 10:36, Jongsung Kim :
>> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: stable <stable@vger.kernel.org> # 3.10+

Applied and queued up for -stable, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-09 19:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-09  8:36 [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit Jongsung Kim
2013-07-09 16:02 ` Nicolas Ferre
2013-07-09 19:50   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).