* [RFC PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization
@ 2013-07-11 0:27 Fan Du
2013-07-11 7:32 ` Nicolas Dichtel
2013-07-11 10:16 ` Hannes Frederic Sowa
0 siblings, 2 replies; 3+ messages in thread
From: Fan Du @ 2013-07-11 0:27 UTC (permalink / raw)
To: nicolas.dichtel; +Cc: yoshfuji, jmorris, kuznet, davem, netdev
Seting rt->rt6i_nsiblings to zero is rebundant, because above memset
has zeroed the rest of rt excluding the first dst memember.
Signed-off-by: Fan Du <fan.du@windriver.com>
---
net/ipv6/route.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 7ca87b3..b88f99f 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -278,7 +278,6 @@ static inline struct rt6_info *ip6_dst_alloc(struct net *net,
rt6_init_peer(rt, table ? &table->tb6_peers : net->ipv6.peers);
rt->rt6i_genid = rt_genid(net);
INIT_LIST_HEAD(&rt->rt6i_siblings);
- rt->rt6i_nsiblings = 0;
}
return rt;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization
2013-07-11 0:27 [RFC PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization Fan Du
@ 2013-07-11 7:32 ` Nicolas Dichtel
2013-07-11 10:16 ` Hannes Frederic Sowa
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dichtel @ 2013-07-11 7:32 UTC (permalink / raw)
To: Fan Du; +Cc: yoshfuji, jmorris, kuznet, davem, netdev
Le 11/07/2013 02:27, Fan Du a écrit :
> Seting rt->rt6i_nsiblings to zero is rebundant, because above memset
> has zeroed the rest of rt excluding the first dst memember.
>
> Signed-off-by: Fan Du <fan.du@windriver.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> net/ipv6/route.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 7ca87b3..b88f99f 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -278,7 +278,6 @@ static inline struct rt6_info *ip6_dst_alloc(struct net *net,
> rt6_init_peer(rt, table ? &table->tb6_peers : net->ipv6.peers);
> rt->rt6i_genid = rt_genid(net);
> INIT_LIST_HEAD(&rt->rt6i_siblings);
> - rt->rt6i_nsiblings = 0;
> }
> return rt;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization
2013-07-11 0:27 [RFC PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization Fan Du
2013-07-11 7:32 ` Nicolas Dichtel
@ 2013-07-11 10:16 ` Hannes Frederic Sowa
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Frederic Sowa @ 2013-07-11 10:16 UTC (permalink / raw)
To: Fan Du; +Cc: nicolas.dichtel, yoshfuji, jmorris, kuznet, davem, netdev
On Thu, Jul 11, 2013 at 08:27:22AM +0800, Fan Du wrote:
> Seting rt->rt6i_nsiblings to zero is rebundant, because above memset
> has zeroed the rest of rt excluding the first dst memember.
>
> Signed-off-by: Fan Du <fan.du@windriver.com>
Altough, net-next is currently not open:
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Maybe you have to resend this patch when net-next is announced open again.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-11 10:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-11 0:27 [RFC PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization Fan Du
2013-07-11 7:32 ` Nicolas Dichtel
2013-07-11 10:16 ` Hannes Frederic Sowa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).