From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [Patch net-next 0/7] net: introduce generic type and helpers for IP address
Date: Wed, 24 Jul 2013 14:28:17 -0700 (PDT) [thread overview]
Message-ID: <20130724.142817.216302535679937307.davem@davemloft.net> (raw)
In-Reply-To: <1374476713-8838-1-git-send-email-amwang@redhat.com>
From: Cong Wang <amwang@redhat.com>
Date: Mon, 22 Jul 2013 15:05:06 +0800
> From: Cong Wang <amwang@redhat.com>
>
> As IPv6 becomes popular, more and more subsystems begin to support IPv6,
> therefore we need a generic IP address type, in case of duplicates.
> Also we will also need some helpers to compare, print, check the generic
> IP address.
>
> This patchset introduce a new type union inet_addr as a union of IPv4
> and IPv6 address, and some helper functions that will be used by existing
> code and in the future VXLAN module.
>
> However, due to ABI limit, we still can't convert union nf_inet_addr
> to union inet_addr.
>
> Signed-off-by: Cong Wang <amwang@redhat.com>
I'm sorry I really don't like these changes at all.
You're creating bloat in places that don't need a full sockaddr_in{,6}.
There is a reason some of these pieces of code used custom types, to
minimize the overhead.
I'm not applying these patches, sorry.
next prev parent reply other threads:[~2013-07-24 21:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 7:05 [Patch net-next 0/7] net: introduce generic type and helpers for IP address Cong Wang
2013-07-22 7:05 ` [Patch net-next 1/7] net: introduce generic union inet_addr Cong Wang
2013-07-22 7:05 ` [Patch net-next 2/7] net: introduce generic simple_inet_pton() Cong Wang
2013-07-22 7:05 ` [Patch net-next 3/7] inetpeer: use generic union inet_addr Cong Wang
2013-07-22 15:18 ` Eric Dumazet
2013-07-23 2:05 ` Cong Wang
2013-07-23 2:26 ` Eric Dumazet
2013-07-23 3:38 ` Cong Wang
2013-07-22 7:05 ` [Patch net-next 4/7] sunrpc: " Cong Wang
[not found] ` <1374476713-8838-5-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-07-23 16:40 ` J. Bruce Fields
[not found] ` <20130723164051.GE12569-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-07-25 12:34 ` Cong Wang
2013-07-25 12:54 ` J. Bruce Fields
2013-07-22 7:05 ` [Patch net-next 5/7] fs: use generic union inet_addr and help functions Cong Wang
2013-07-22 7:05 ` [Patch net-next 6/7] sctp: use generic union inet_addr Cong Wang
2013-07-22 7:05 ` [Patch net-next 7/7] selinux: " Cong Wang
2013-07-22 20:36 ` Paul Moore
2013-07-23 2:07 ` Cong Wang
2013-07-22 20:44 ` [Patch net-next 0/7] net: introduce generic type and helpers for IP address Joe Perches
2013-07-23 2:00 ` Cong Wang
2013-07-23 2:16 ` Joe Perches
2013-07-23 2:26 ` Cong Wang
2013-07-24 21:28 ` David Miller [this message]
2013-07-25 12:30 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724.142817.216302535679937307.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).