From: "J. Bruce Fields" <bfields@fieldses.org>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org
Subject: Re: [Patch net-next 4/7] sunrpc: use generic union inet_addr
Date: Thu, 25 Jul 2013 08:54:05 -0400 [thread overview]
Message-ID: <20130725125405.GC5777@fieldses.org> (raw)
In-Reply-To: <1374755683.29923.7.camel@cr0>
On Thu, Jul 25, 2013 at 08:34:43PM +0800, Cong Wang wrote:
> On Tue, 2013-07-23 at 12:40 -0400, J. Bruce Fields wrote:
> > On Mon, Jul 22, 2013 at 03:05:10PM +0800, Cong Wang wrote:
> > > static inline unsigned short rpc_get_port(const struct sockaddr *sap)
> > > {
> > > - switch (sap->sa_family) {
> > > - case AF_INET:
> > > - return ntohs(((struct sockaddr_in *)sap)->sin_port);
> > > - case AF_INET6:
> > > - return ntohs(((struct sockaddr_in6 *)sap)->sin6_port);
> > > - }
> > > - return 0;
> > > + return inet_addr_get_port((const union inet_addr *)sap);
> > > }
> >
> > Is there any reason to keep the rpc_get_port wrapper at all after this?
> > Or if its still useful to have the convenience of not having to do the
> > cast, maybe the wrapper should move to common code to? (Is there some
> > reason only the rpc code needs this?)
> >
>
> Yeah, the only reason why I keep it is that I don't want to touch all
> the callers of rpc_get_port().
Makes sense, thanks.
--b.
> I agree that we can make it a generic
> function.
>
> Thanks.
>
next prev parent reply other threads:[~2013-07-25 12:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 7:05 [Patch net-next 0/7] net: introduce generic type and helpers for IP address Cong Wang
2013-07-22 7:05 ` [Patch net-next 1/7] net: introduce generic union inet_addr Cong Wang
2013-07-22 7:05 ` [Patch net-next 2/7] net: introduce generic simple_inet_pton() Cong Wang
2013-07-22 7:05 ` [Patch net-next 3/7] inetpeer: use generic union inet_addr Cong Wang
2013-07-22 15:18 ` Eric Dumazet
2013-07-23 2:05 ` Cong Wang
2013-07-23 2:26 ` Eric Dumazet
2013-07-23 3:38 ` Cong Wang
2013-07-22 7:05 ` [Patch net-next 4/7] sunrpc: " Cong Wang
[not found] ` <1374476713-8838-5-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-07-23 16:40 ` J. Bruce Fields
[not found] ` <20130723164051.GE12569-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-07-25 12:34 ` Cong Wang
2013-07-25 12:54 ` J. Bruce Fields [this message]
2013-07-22 7:05 ` [Patch net-next 5/7] fs: use generic union inet_addr and help functions Cong Wang
2013-07-22 7:05 ` [Patch net-next 6/7] sctp: use generic union inet_addr Cong Wang
2013-07-22 7:05 ` [Patch net-next 7/7] selinux: " Cong Wang
2013-07-22 20:36 ` Paul Moore
2013-07-23 2:07 ` Cong Wang
2013-07-22 20:44 ` [Patch net-next 0/7] net: introduce generic type and helpers for IP address Joe Perches
2013-07-23 2:00 ` Cong Wang
2013-07-23 2:16 ` Joe Perches
2013-07-23 2:26 ` Cong Wang
2013-07-24 21:28 ` David Miller
2013-07-25 12:30 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725125405.GC5777@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).