netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: sun4i: fix timeout check
@ 2013-07-23  1:09 Emilio López
  2013-07-23 13:31 ` Maxime Ripard
  0 siblings, 1 reply; 3+ messages in thread
From: Emilio López @ 2013-07-23  1:09 UTC (permalink / raw)
  To: Maxime Ripard, davem; +Cc: netdev, Emilio López

The current timeout check is comparing two constant values, so it won't
ever detect a timeout. This patch reworks the affected code a bit so it
has a chance at detecting timeouts correctly.

Signed-off-by: Emilio López <emilio@elopez.com.ar>
---
 drivers/net/phy/mdio-sun4i.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/net/phy/mdio-sun4i.c b/drivers/net/phy/mdio-sun4i.c
index 61d3f4e..7f25e49 100644
--- a/drivers/net/phy/mdio-sun4i.c
+++ b/drivers/net/phy/mdio-sun4i.c
@@ -40,7 +40,7 @@ struct sun4i_mdio_data {
 static int sun4i_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
 {
 	struct sun4i_mdio_data *data = bus->priv;
-	unsigned long start_jiffies;
+	unsigned long timeout_jiffies;
 	int value;
 
 	/* issue the phy address and reg */
@@ -49,10 +49,9 @@ static int sun4i_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
 	writel(0x1, data->membase + EMAC_MAC_MCMD_REG);
 
 	/* Wait read complete */
-	start_jiffies = jiffies;
+	timeout_jiffies = jiffies + MDIO_TIMEOUT;
 	while (readl(data->membase + EMAC_MAC_MIND_REG) & 0x1) {
-		if (time_after(start_jiffies,
-			       start_jiffies + MDIO_TIMEOUT))
+		if (time_is_before_jiffies(timeout_jiffies))
 			return -ETIMEDOUT;
 		msleep(1);
 	}
@@ -69,7 +68,7 @@ static int sun4i_mdio_write(struct mii_bus *bus, int mii_id, int regnum,
 			    u16 value)
 {
 	struct sun4i_mdio_data *data = bus->priv;
-	unsigned long start_jiffies;
+	unsigned long timeout_jiffies;
 
 	/* issue the phy address and reg */
 	writel((mii_id << 8) | regnum, data->membase + EMAC_MAC_MADR_REG);
@@ -77,10 +76,9 @@ static int sun4i_mdio_write(struct mii_bus *bus, int mii_id, int regnum,
 	writel(0x1, data->membase + EMAC_MAC_MCMD_REG);
 
 	/* Wait read complete */
-	start_jiffies = jiffies;
+	timeout_jiffies = jiffies + MDIO_TIMEOUT;
 	while (readl(data->membase + EMAC_MAC_MIND_REG) & 0x1) {
-		if (time_after(start_jiffies,
-			       start_jiffies + MDIO_TIMEOUT))
+		if (time_is_before_jiffies(timeout_jiffies))
 			return -ETIMEDOUT;
 		msleep(1);
 	}
-- 
1.8.3.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: sun4i: fix timeout check
  2013-07-23  1:09 [PATCH] net: sun4i: fix timeout check Emilio López
@ 2013-07-23 13:31 ` Maxime Ripard
  2013-07-25  0:04   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2013-07-23 13:31 UTC (permalink / raw)
  To: Emilio López; +Cc: davem, netdev

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

On Mon, Jul 22, 2013 at 10:09:18PM -0300, Emilio López wrote:
> The current timeout check is comparing two constant values, so it won't
> ever detect a timeout. This patch reworks the affected code a bit so it
> has a chance at detecting timeouts correctly.
> 
> Signed-off-by: Emilio López <emilio@elopez.com.ar>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: sun4i: fix timeout check
  2013-07-23 13:31 ` Maxime Ripard
@ 2013-07-25  0:04   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-07-25  0:04 UTC (permalink / raw)
  To: maxime.ripard; +Cc: emilio, netdev

From: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Tue, 23 Jul 2013 15:31:14 +0200

> On Mon, Jul 22, 2013 at 10:09:18PM -0300, Emilio López wrote:
>> The current timeout check is comparing two constant values, so it won't
>> ever detect a timeout. This patch reworks the affected code a bit so it
>> has a chance at detecting timeouts correctly.
>> 
>> Signed-off-by: Emilio López <emilio@elopez.com.ar>
> 
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-25  0:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-23  1:09 [PATCH] net: sun4i: fix timeout check Emilio López
2013-07-23 13:31 ` Maxime Ripard
2013-07-25  0:04   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).