From: Simon Horman <horms@verge.net.au>
To: Julian Anastasov <ja@ssi.bg>
Cc: Joe Stringer <joe@wand.net.nz>,
davem@davemloft.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, lvs-devel@vger.kernel.org,
pablo@netfilter.org, jesse@nicira.com
Subject: Re: [PATCH v2 net-next] net/sctp: Refactor SCTP skb checksum computation
Date: Thu, 25 Jul 2013 14:24:38 +0900 [thread overview]
Message-ID: <20130725052437.GB25854@verge.net.au> (raw)
In-Reply-To: <alpine.LFD.2.00.1307250804180.1718@ja.ssi.bg>
On Thu, Jul 25, 2013 at 08:08:11AM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Thu, 25 Jul 2013, Joe Stringer wrote:
>
> > This patch consolidates the SCTP checksum calculation code from various
> > places to a single new function, sctp_compute_cksum(skb, offset).
> >
> > Signed-off-by: Joe Stringer <joe@wand.net.nz>
> > ---
> > v2:
> > * Use skb->data + offset for start position of checksum calculation
> > * Fix existing bug in sctp_csum_check() where the incorrect offset was used
> > * Remove redundant variable in sctp_nat_csum()
>
> v2 looks good to me, thanks!
>
> Reviewed-by: Julian Anastasov <ja@ssi.bg>
IPVS portion:
Acked-by: Simon Horman <horms@verge.net.au>
Dave, could you consider taking this through net-next?
> > ---
> > include/net/sctp/checksum.h | 15 +++++++++++++++
> > net/netfilter/ipvs/ip_vs_proto_sctp.c | 23 +++--------------------
> > net/netfilter/nf_nat_proto_sctp.c | 8 +-------
> > net/sctp/input.c | 10 +---------
> > 4 files changed, 20 insertions(+), 36 deletions(-)
>
> Regards
>
> --
> Julian Anastasov <ja@ssi.bg>
>
next prev parent reply other threads:[~2013-07-25 5:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 1:52 [PATCH v2 net-next] net/sctp: Refactor SCTP skb checksum computation Joe Stringer
2013-07-25 5:08 ` Julian Anastasov
2013-07-25 5:24 ` Simon Horman [this message]
2013-07-25 6:15 ` David Miller
2013-07-28 3:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725052437.GB25854@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=jesse@nicira.com \
--cc=joe@wand.net.nz \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).