From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bhutchings@solarflare.com, oliver@neukum.org,
grundler@google.com, freddy@asix.com.tw, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
louis@asix.com.tw, allan@asix.com.tw
Subject: Re: [PATCH] usbnet: do not pretend to support SG/TSO
Date: Fri, 26 Jul 2013 13:48:41 -0700 (PDT) [thread overview]
Message-ID: <20130726.134841.350005683675289021.davem@davemloft.net> (raw)
In-Reply-To: <1374624954.3449.61.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 23 Jul 2013 17:15:54 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> usbnet doesn't support yet SG, so drivers should not advertise SG or TSO
> capabilities, as they allow TCP stack to build large TSO packets that
> need to be linearized and might use order-5 pages.
>
> This adds an extra copy overhead and possible allocation failures.
>
> Current code ignore skb_linearize() return code so crashes are even
> possible.
>
> Best is to not pretend SG/TSO is supported, and add this again when/if
> usbnet really supports SG for devices who could get a performance gain.
>
> Based on a prior patch from Freddy Xin <freddy@asix.com.tw>
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
next prev parent reply other threads:[~2013-07-26 20:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 9:16 [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A freddy
2013-07-22 17:07 ` Eric Dumazet
2013-07-22 17:11 ` Ben Hutchings
2013-07-22 18:29 ` Grant Grundler
2013-07-22 18:38 ` Ben Hutchings
2013-07-22 18:47 ` Eric Dumazet
2013-07-22 19:47 ` Ben Hutchings
[not found] ` <1374522471.1635.48.camel-/LGg1Z1CJKQ+9kgCwbf1HqK4ta4zdZpAajtMo4Cw6ucAvxtiuMwx3w@public.gmane.org>
2013-07-23 6:10 ` Eric Dumazet
2013-07-23 23:46 ` David Miller
2013-07-23 23:56 ` Eric Dumazet
2013-07-24 0:05 ` Eric Dumazet
2013-07-24 0:15 ` [PATCH] usbnet: do not pretend to support SG/TSO Eric Dumazet
2013-07-26 20:48 ` David Miller [this message]
2013-07-24 0:17 ` [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A David Miller
2013-07-24 2:29 ` Grant Grundler
[not found] ` <CANEJEGtLavwdPdq_Qojz_x-DQ3KXfZp0vPYr6imKtNxN0Hf_2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-24 2:32 ` Grant Grundler
2013-07-25 2:28 ` Ming Lei
2013-07-25 5:10 ` Eric Dumazet
2013-07-25 5:25 ` Ming Lei
[not found] ` <CACVXFVNyFk0Zpi4tC0ENiq8RcrtrjYW-Dhs+A56+Pw4BKm8y8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-25 11:01 ` Eric Dumazet
2013-07-25 14:52 ` Ming Lei
2013-07-25 15:00 ` Ben Hutchings
[not found] ` <CACVXFVNre5SsJhaVqFNRcop7ahqxabWqHZkjBZccj1ZqOAUZ9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-25 15:11 ` Eric Dumazet
2013-07-25 13:34 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726.134841.350005683675289021.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allan@asix.com.tw \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=freddy@asix.com.tw \
--cc=grundler@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=louis@asix.com.tw \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).