From: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, hannes@stressinduktion.org,
bsderandrew@gmail.com
Subject: Re: [PATCH v2 2/2] fib_rules: add .suppress operation
Date: Tue, 30 Jul 2013 09:23:05 +0200 [thread overview]
Message-ID: <20130730072305.GB10550@zirkel.wertarbyte.de> (raw)
In-Reply-To: <20130730.000306.1057653828787681847.davem@davemloft.net>
Dies schrieb David Miller (davem@davemloft.net):
> > +static bool fib4_rule_suppress(struct fib_rule *rule, struct fib_lookup_arg *arg) {
> ...
> > @@ -119,6 +119,18 @@ out:
> > return err;
> > }
> >
> > +static bool fib6_rule_suppress(struct fib_rule *rule, struct fib_lookup_arg *arg) {
> > + struct rt6_info *rt = (struct rt6_info *) arg->result;
> > + /*
> > + * do not accept result if the route does
> > + * not meet the required prefix length
> > + */
>
> Please format this stuff correctly.
>
> Functions are declared like this:
>
> static type NAME(TYPE ARG1, TYPE ARG2)
> {
> }
Noted and fixed.
> You don't put the openning curly brace at the end of the line with the
> closing parenthesis of the argument list.
>
> Next, comments are to be formatted:
>
> /* Like
> * this.
> */
Well, to be fair, most comments in the existing code base actually use the style
I employed (in fact, I was copying it), so it seems like a blurry line at least.
/*
* If we need to find a source address for this traffic,
* we check the result if it meets requirement of the rule.
*/
-----8<----
/*
* If FIB_RULE_FIND_SADDR is set and we do not have a
* source address for the traffic, we defer check for
* source address.
*/
-----8<----
/* The lock is not required here, the list in unreacheable
* at the moment this function is called */
-----8<----
/* compatibility: if the mark value is non-zero all bits
* are compared unless a mask is explicitly specified.
*/
-----8<----
/*
* There are unresolved goto rules in the list, check if
* any of them are pointing to this new rule.
*/
-----8<----
/*
* Check if this rule is a target to any of them. If so,
* disable them. As this operation is eventually very
* expensive, it is only performed if goto rules have
* actually been added.
*/
-----8<----
next prev parent reply other threads:[~2013-07-30 7:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 22:02 [PATCH] fib_rules: add minimum prefix length Stefan Tomanek
2013-07-23 22:38 ` Stephen Hemminger
2013-07-23 22:52 ` Stefan Tomanek
2013-07-24 2:14 ` Hannes Frederic Sowa
2013-07-24 7:57 ` Stefan Tomanek
2013-07-25 16:29 ` Stefan Tomanek
2013-07-25 17:43 ` [PATCH] fib_rules/fib6rules: " Stefan Tomanek
2013-07-25 18:17 ` [PATCH] fib_rules: " Hannes Frederic Sowa
2013-07-25 18:28 ` Stefan Tomanek
2013-07-25 21:46 ` Andrew Collins
2013-07-25 22:11 ` Stefan Tomanek
2013-07-26 10:46 ` [PATCH] fib_rules: add .suppress operation Stefan Tomanek
2013-07-26 17:05 ` Hannes Frederic Sowa
2013-07-27 6:08 ` Hannes Frederic Sowa
2013-07-27 6:26 ` Hannes Frederic Sowa
2013-07-27 7:07 ` Hannes Frederic Sowa
2013-07-27 10:21 ` Stefan Tomanek
2013-07-27 15:10 ` Hannes Frederic Sowa
2013-07-28 10:36 ` Stefan Tomanek
2013-07-30 6:52 ` [PATCH v2 1/2] fib6_rules: make error handling consistent with IPv4 Stefan Tomanek
2013-07-30 6:53 ` [PATCH v2 2/2] fib_rules: add .suppress operation Stefan Tomanek
2013-07-30 7:03 ` David Miller
2013-07-30 7:23 ` Stefan Tomanek [this message]
2013-07-30 7:34 ` David Miller
2013-07-30 7:46 ` [PATCH v3] " Stefan Tomanek
2013-07-31 22:13 ` David Miller
2013-08-01 0:24 ` Stefan Tomanek
2013-08-01 0:26 ` David Miller
2013-08-01 0:17 ` [PATCH v4] " Stefan Tomanek
2013-08-01 0:27 ` David Miller
2013-08-01 1:26 ` Stefan Tomanek
2013-08-01 5:35 ` Hannes Frederic Sowa
2013-07-26 10:54 ` [PATCH] fib_rules: add minimum prefix length Stefan Tomanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730072305.GB10550@zirkel.wertarbyte.de \
--to=stefan.tomanek@wertarbyte.de \
--cc=bsderandrew@gmail.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).