* [patch] net_sched: info leak in atm_tc_dump_class()
@ 2013-07-30 10:23 Dan Carpenter
2013-07-30 11:18 ` Jiri Pirko
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2013-07-30 10:23 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: David S. Miller, netdev, kernel-janitors
The "pvc" struct has a hole after pvc.sap_family which is not cleared.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
index ca8e0a5..1f9c314 100644
--- a/net/sched/sch_atm.c
+++ b/net/sched/sch_atm.c
@@ -605,6 +605,7 @@ static int atm_tc_dump_class(struct Qdisc *sch, unsigned long cl,
struct sockaddr_atmpvc pvc;
int state;
+ memset(&pvc, 0, sizeof(pvc));
pvc.sap_family = AF_ATMPVC;
pvc.sap_addr.itf = flow->vcc->dev ? flow->vcc->dev->number : -1;
pvc.sap_addr.vpi = flow->vcc->vpi;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] net_sched: info leak in atm_tc_dump_class()
2013-07-30 10:23 [patch] net_sched: info leak in atm_tc_dump_class() Dan Carpenter
@ 2013-07-30 11:18 ` Jiri Pirko
2013-07-31 22:04 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Pirko @ 2013-07-30 11:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jamal Hadi Salim, David S. Miller, netdev, kernel-janitors
Tue, Jul 30, 2013 at 12:23:39PM CEST, dan.carpenter@oracle.com wrote:
>The "pvc" struct has a hole after pvc.sap_family which is not cleared.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] net_sched: info leak in atm_tc_dump_class()
2013-07-30 11:18 ` Jiri Pirko
@ 2013-07-31 22:04 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-07-31 22:04 UTC (permalink / raw)
To: jiri; +Cc: dan.carpenter, jhs, netdev, kernel-janitors
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 30 Jul 2013 13:18:20 +0200
> Tue, Jul 30, 2013 at 12:23:39PM CEST, dan.carpenter@oracle.com wrote:
>>The "pvc" struct has a hole after pvc.sap_family which is not cleared.
>>
>>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-31 22:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-30 10:23 [patch] net_sched: info leak in atm_tc_dump_class() Dan Carpenter
2013-07-30 11:18 ` Jiri Pirko
2013-07-31 22:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).