From: Stephen Hemminger <stephen@networkplumber.org>
To: Pravin Shelar <pshelar@nicira.com>
Cc: David Miller <davem@davemloft.net>,
Thomas Richter <tmricht@linux.vnet.ibm.com>,
Mike Rapoport <mike.rapoport@ravellosystems.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] vxlan: fix rcu related warnings
Date: Tue, 30 Jul 2013 16:02:45 -0700 [thread overview]
Message-ID: <20130730160245.4b7b84a1@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <CALnjE+qx1L5p6CzFcd4nMTvWbxm-7_bz10wjbuUJdt12Q4Kqpg@mail.gmail.com>
On Tue, 30 Jul 2013 15:17:21 -0700
Pravin Shelar <pshelar@nicira.com> wrote:
> On Tue, Jul 30, 2013 at 1:18 PM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > Vxlan remote list is protected by RCU but since first_remote
> > returns a bare pointer, sparse complains.
> > Split out the rcu and non-rcu access to the list.
> >
> > Ok to replace list_for_or_null with just list_entry_rcu because
> > remotes list must be non-empty.
> >
> I am still getting following sparse waning.
>
> CHECK drivers/net/vxlan.c
> drivers/net/vxlan.c:181:16: warning: incorrect type in return
> expression (different address spaces)
> drivers/net/vxlan.c:181:16: expected struct vxlan_rdst [noderef] <asn:4>*
> drivers/net/vxlan.c:181:16: got struct vxlan_rdst *<noident>
> drivers/net/vxlan.c:748:59: warning: incorrect type in initializer
> (different address spaces)
> drivers/net/vxlan.c:748:59: expected struct vxlan_rdst *rdst
> drivers/net/vxlan.c:748:59: got struct vxlan_rdst [noderef] <asn:4>*
> drivers/net/vxlan.c:181:16: warning: incorrect type in return
> expression (different address spaces)
> drivers/net/vxlan.c:181:16: expected struct vxlan_rdst [noderef] <asn:4>*
> drivers/net/vxlan.c:181:16: got struct vxlan_rdst *<noident>
> drivers/net/vxlan.c:996:42: warning: dereference of noderef expression
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Which version of sparse? I don't see this with latest version.
next prev parent reply other threads:[~2013-07-30 23:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 20:18 [PATCH net-next] vxlan: fix rcu related warnings Stephen Hemminger
2013-07-30 22:17 ` Pravin Shelar
2013-07-30 23:02 ` Stephen Hemminger [this message]
2013-07-30 23:04 ` Eric Dumazet
2013-07-31 0:35 ` Stephen Hemminger
2013-07-31 17:57 ` Pravin Shelar
2013-08-05 0:17 ` [PATCH net-next v3] vxlan: fix rcu related warning Stephen Hemminger
2013-08-05 1:47 ` David Miller
2013-07-30 23:20 ` [PATCH net-next] vxlan: fix rcu related warnings Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730160245.4b7b84a1@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=mike.rapoport@ravellosystems.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=tmricht@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).