Re: [PATCH net-next] vxlan: fix rcu related warnings

[Pravin Shelar <pshelar@nicira.com>]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

On Tue, Jul 30, 2013 at 5:35 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Tue, 30 Jul 2013 16:04:59 -0700
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> On Tue, 2013-07-30 at 16:02 -0700, Stephen Hemminger wrote:
>>
>> > Which version of sparse? I don't see this with latest version.
>>
>> Make sure you have CONFIG_SPARSE_RCU_POINTER=y
>>
>>
>
> I have it enabled. And am using latest version from git.

Attached patch fixes warnings for me.

[-- Attachment #2: 0002-vxlan-fix-rcu-warn.patch --]
[-- Type: application/octet-stream, Size: 877 bytes --]

From 805650bc435b99cbcc02829039a0c3a877416fd9 Mon Sep 17 00:00:00 2001
From: Pravin B Shelar <pshelar@nicira.com>
Date: Wed, 31 Jul 2013 10:52:59 -0700
Subject: [PATCH net-next] vxlan: fix rcu warn.

---
 drivers/net/vxlan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 31718c6..e4d1513 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -176,7 +176,7 @@ static inline struct hlist_head *vs_head(struct net *net, __be16 port)
 /* First remote destination for a forwarding entry.
  * Guaranteed to be non-NULL because remotes are never deleted.
  */
-static inline struct vxlan_rdst __rcu *first_remote_rcu(struct vxlan_fdb *fdb)
+static inline struct vxlan_rdst *first_remote_rcu(struct vxlan_fdb *fdb)
 {
 	return list_entry_rcu(fdb->remotes.next, struct vxlan_rdst, list);
 }
-- 
1.7.1