* [PATCH] macvlan: fix typo in assignment
@ 2013-08-28 11:34 Lutz Jaenicke
2013-08-30 21:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Lutz Jaenicke @ 2013-08-28 11:34 UTC (permalink / raw)
To: netdev; +Cc: Lutz Jaenicke
commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f
"[NET]: Move hardware header operations out of netdevice."
moved the handling into macvlan setup adding
dev->header_ops = &macvlan_hard_header_ops,
At the end of the line the ',' should have been a ';'
Signed-off-by: Lutz Jaenicke <ljaenicke@innominate.com>
---
drivers/net/macvlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 16b43bf..4e2698d 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -683,7 +683,7 @@ void macvlan_common_setup(struct net_device *dev)
dev->priv_flags |= IFF_UNICAST_FLT;
dev->netdev_ops = &macvlan_netdev_ops;
dev->destructor = free_netdev;
- dev->header_ops = &macvlan_hard_header_ops,
+ dev->header_ops = &macvlan_hard_header_ops;
dev->ethtool_ops = &macvlan_ethtool_ops;
}
EXPORT_SYMBOL_GPL(macvlan_common_setup);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] macvlan: fix typo in assignment
2013-08-28 11:34 [PATCH] macvlan: fix typo in assignment Lutz Jaenicke
@ 2013-08-30 21:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-08-30 21:31 UTC (permalink / raw)
To: ljaenicke; +Cc: netdev
From: Lutz Jaenicke <ljaenicke@innominate.com>
Date: Wed, 28 Aug 2013 13:34:31 +0200
> commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f
> "[NET]: Move hardware header operations out of netdevice."
> moved the handling into macvlan setup adding
> dev->header_ops = &macvlan_hard_header_ops,
> At the end of the line the ',' should have been a ';'
>
> Signed-off-by: Lutz Jaenicke <ljaenicke@innominate.com>
This is a harmless error, because semantically it causes no bug.
So this is a cleanup and I've thus applied it to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-30 21:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-28 11:34 [PATCH] macvlan: fix typo in assignment Lutz Jaenicke
2013-08-30 21:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).