* [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
@ 2013-08-30 3:29 Chen Gang
2013-08-30 14:36 ` Paul Gortmaker
0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2013-08-30 3:29 UTC (permalink / raw)
To: Paul Gortmaker, Yoshinori Sato, Kees Cook; +Cc: David Miller, netdev
Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it
will no related irq and base address).
The release error:
CC [M] drivers/net/hamradio/bpqether.o
drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function)
drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant
drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function)
drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function)
drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function)
drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/net/ethernet/8390/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
index a5f91e1..becef25 100644
--- a/drivers/net/ethernet/8390/Kconfig
+++ b/drivers/net/ethernet/8390/Kconfig
@@ -148,7 +148,7 @@ config PCMCIA_PCNET
config NE_H8300
tristate "NE2000 compatible support for H8/300"
- depends on H8300
+ depends on H8300H_AKI3068NET || H8300H_H8MAX
---help---
Say Y here if you want to use the NE2000 compatible
controller on the Renesas H8/300 processor.
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
2013-08-30 3:29 [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300 Chen Gang
@ 2013-08-30 14:36 ` Paul Gortmaker
2013-09-02 1:48 ` Chen Gang
2013-09-02 2:20 ` [PATCH v2] " Chen Gang
0 siblings, 2 replies; 7+ messages in thread
From: Paul Gortmaker @ 2013-08-30 14:36 UTC (permalink / raw)
To: Chen Gang; +Cc: Yoshinori Sato, Kees Cook, David Miller, netdev
[[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300] On 30/08/2013 (Fri 11:29) Chen Gang wrote:
> Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it
> will no related irq and base address).
Do you have an H83000 and really know that is true? I'm guessing no.
Looking at the driver, it is kind of broken that it only assigns I/O and
irq for two platforms, but the H8300 arch Kconfig.cpu only allows building
a single platform in a given kernel anyway, so a dependency fix is
probably acceptable here.
Given that, what you really want to indicate is something like:
Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
I/O base and IRQ values for the NE_H8300 driver. Hence builds
for other H8300H platforms will fail as per below. Since H8300H
does not support multi platform builds, we simply limit building
the driver to those two platforms specifically.
>
> The release error:
>
> CC [M] drivers/net/hamradio/bpqether.o
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This file has nothing to do with the problem in question. [If you are
going to do a "make -j30" in testing, then at least restart with -j1 to
properly capture the error message.]
Please update the commit log appropriately and resubmit.
Paul.
--
> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function)
> drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant
> drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function)
> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
> drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function)
> drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function)
> drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> drivers/net/ethernet/8390/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
> index a5f91e1..becef25 100644
> --- a/drivers/net/ethernet/8390/Kconfig
> +++ b/drivers/net/ethernet/8390/Kconfig
> @@ -148,7 +148,7 @@ config PCMCIA_PCNET
>
> config NE_H8300
> tristate "NE2000 compatible support for H8/300"
> - depends on H8300
> + depends on H8300H_AKI3068NET || H8300H_H8MAX
> ---help---
> Say Y here if you want to use the NE2000 compatible
> controller on the Renesas H8/300 processor.
> --
> 1.7.7.6
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
2013-08-30 14:36 ` Paul Gortmaker
@ 2013-09-02 1:48 ` Chen Gang
2013-09-02 2:39 ` Chen Gang
2013-09-02 2:20 ` [PATCH v2] " Chen Gang
1 sibling, 1 reply; 7+ messages in thread
From: Chen Gang @ 2013-09-02 1:48 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Yoshinori Sato, Kees Cook, David Miller, netdev
On 08/30/2013 10:36 PM, Paul Gortmaker wrote:
> [[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300] On 30/08/2013 (Fri 11:29) Chen Gang wrote:
>
>> Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it
>> will no related irq and base address).
>
> Do you have an H83000 and really know that is true? I'm guessing no.
>
> Looking at the driver, it is kind of broken that it only assigns I/O and
> irq for two platforms, but the H8300 arch Kconfig.cpu only allows building
> a single platform in a given kernel anyway, so a dependency fix is
> probably acceptable here.
>
OK, thanks.
> Given that, what you really want to indicate is something like:
>
> Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
> I/O base and IRQ values for the NE_H8300 driver. Hence builds
> for other H8300H platforms will fail as per below. Since H8300H
> does not support multi platform builds, we simply limit building
> the driver to those two platforms specifically.
>
Hmm... that sounds good to me.
>>
>> The release error:
>>
>> CC [M] drivers/net/hamradio/bpqether.o
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> This file has nothing to do with the problem in question. [If you are
> going to do a "make -j30" in testing, then at least restart with -j1 to
> properly capture the error message.]
>
Oh, it is a waste, which I should remove, thanks.
> Please update the commit log appropriately and resubmit.
>
OK, I will send patch v2.
> Paul.
> --
>
>> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
>> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function)
>> drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant
>> drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function)
>> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
>> drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function)
>> drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function)
>> drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>> drivers/net/ethernet/8390/Kconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
>> index a5f91e1..becef25 100644
>> --- a/drivers/net/ethernet/8390/Kconfig
>> +++ b/drivers/net/ethernet/8390/Kconfig
>> @@ -148,7 +148,7 @@ config PCMCIA_PCNET
>>
>> config NE_H8300
>> tristate "NE2000 compatible support for H8/300"
>> - depends on H8300
>> + depends on H8300H_AKI3068NET || H8300H_H8MAX
>> ---help---
>> Say Y here if you want to use the NE2000 compatible
>> controller on the Renesas H8/300 processor.
>> --
>> 1.7.7.6
>
>
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
2013-08-30 14:36 ` Paul Gortmaker
2013-09-02 1:48 ` Chen Gang
@ 2013-09-02 2:20 ` Chen Gang
2013-09-04 2:37 ` David Miller
1 sibling, 1 reply; 7+ messages in thread
From: Chen Gang @ 2013-09-02 2:20 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Yoshinori Sato, Kees Cook, David Miller, netdev
Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
I/O base and IRQ values for the NE_H8300 driver. Hence builds
for other H8300H platforms will fail as per below. Since H8300H
does not support multi platform builds, we simply limit building
the driver to those two platforms specifically.
The release error:
drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function)
drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant
drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function)
drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function)
drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function)
drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/net/ethernet/8390/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
index a5f91e1..becef25 100644
--- a/drivers/net/ethernet/8390/Kconfig
+++ b/drivers/net/ethernet/8390/Kconfig
@@ -148,7 +148,7 @@ config PCMCIA_PCNET
config NE_H8300
tristate "NE2000 compatible support for H8/300"
- depends on H8300
+ depends on H8300H_AKI3068NET || H8300H_H8MAX
---help---
Say Y here if you want to use the NE2000 compatible
controller on the Renesas H8/300 processor.
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
2013-09-02 1:48 ` Chen Gang
@ 2013-09-02 2:39 ` Chen Gang
0 siblings, 0 replies; 7+ messages in thread
From: Chen Gang @ 2013-09-02 2:39 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Yoshinori Sato, Kees Cook, David Miller, netdev
On 09/02/2013 09:48 AM, Chen Gang wrote:
> On 08/30/2013 10:36 PM, Paul Gortmaker wrote:
>> [[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300] On 30/08/2013 (Fri 11:29) Chen Gang wrote:
>>
>>> Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it
>>> will no related irq and base address).
>>
>> Do you have an H83000 and really know that is true? I'm guessing no.
Oh, sorry, forgot reply this item.
And I have no related hardware (I am just cross compiling).
Hmm... according to the implementation, we can assume original author
though: "currently only H8300H_AKI3068NET and H8300H_H8MAX can/need
support NE_H8300" (may better use "need" instead of "can").
Thanks.
>>
>> Looking at the driver, it is kind of broken that it only assigns I/O and
>> irq for two platforms, but the H8300 arch Kconfig.cpu only allows building
>> a single platform in a given kernel anyway, so a dependency fix is
>> probably acceptable here.
>>
>
> OK, thanks.
>
>> Given that, what you really want to indicate is something like:
>>
>> Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
>> I/O base and IRQ values for the NE_H8300 driver. Hence builds
>> for other H8300H platforms will fail as per below. Since H8300H
>> does not support multi platform builds, we simply limit building
>> the driver to those two platforms specifically.
>>
>
> Hmm... that sounds good to me.
>
>>>
>>> The release error:
>>>
>>> CC [M] drivers/net/hamradio/bpqether.o
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> This file has nothing to do with the problem in question. [If you are
>> going to do a "make -j30" in testing, then at least restart with -j1 to
>> properly capture the error message.]
>>
>
> Oh, it is a waste, which I should remove, thanks.
>
>
>> Please update the commit log appropriately and resubmit.
>>
>
> OK, I will send patch v2.
>
>> Paul.
>> --
>>
>>> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
>>> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function)
>>> drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant
>>> drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function)
>>> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
>>> drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function)
>>> drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function)
>>> drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>> ---
>>> drivers/net/ethernet/8390/Kconfig | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
>>> index a5f91e1..becef25 100644
>>> --- a/drivers/net/ethernet/8390/Kconfig
>>> +++ b/drivers/net/ethernet/8390/Kconfig
>>> @@ -148,7 +148,7 @@ config PCMCIA_PCNET
>>>
>>> config NE_H8300
>>> tristate "NE2000 compatible support for H8/300"
>>> - depends on H8300
>>> + depends on H8300H_AKI3068NET || H8300H_H8MAX
>>> ---help---
>>> Say Y here if you want to use the NE2000 compatible
>>> controller on the Renesas H8/300 processor.
>>> --
>>> 1.7.7.6
>>
>>
>
> Thanks.
>
--
Chen Gang
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
2013-09-02 2:20 ` [PATCH v2] " Chen Gang
@ 2013-09-04 2:37 ` David Miller
2013-09-04 2:52 ` Chen Gang
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2013-09-04 2:37 UTC (permalink / raw)
To: gang.chen; +Cc: paul.gortmaker, ysato, keescook, netdev
From: Chen Gang <gang.chen@asianux.com>
Date: Mon, 02 Sep 2013 10:20:02 +0800
> Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
> I/O base and IRQ values for the NE_H8300 driver. Hence builds
> for other H8300H platforms will fail as per below. Since H8300H
> does not support multi platform builds, we simply limit building
> the driver to those two platforms specifically.
>
> The release error:
...
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
2013-09-04 2:37 ` David Miller
@ 2013-09-04 2:52 ` Chen Gang
0 siblings, 0 replies; 7+ messages in thread
From: Chen Gang @ 2013-09-04 2:52 UTC (permalink / raw)
To: David Miller; +Cc: paul.gortmaker, ysato, keescook, netdev
On 09/04/2013 10:37 AM, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Mon, 02 Sep 2013 10:20:02 +0800
>
>> Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
>> I/O base and IRQ values for the NE_H8300 driver. Hence builds
>> for other H8300H platforms will fail as per below. Since H8300H
>> does not support multi platform builds, we simply limit building
>> the driver to those two platforms specifically.
>>
>> The release error:
> ...
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> Applied, thanks.
>
>
Thank you too.
And h8300 architecture will be remove from Linux kernel (and I am sorry
for forgot to notifying Paul about it),
Do we still need this patch (I am not quite sure, maybe we still need) ?
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-09-04 2:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-30 3:29 [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300 Chen Gang
2013-08-30 14:36 ` Paul Gortmaker
2013-09-02 1:48 ` Chen Gang
2013-09-02 2:39 ` Chen Gang
2013-09-02 2:20 ` [PATCH v2] " Chen Gang
2013-09-04 2:37 ` David Miller
2013-09-04 2:52 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).