* [PATCH] Add missing braces to do_tcp_setsockopt
@ 2013-09-05 17:43 Dave Jones
2013-09-05 17:55 ` Neal Cardwell
0 siblings, 1 reply; 4+ messages in thread
From: Dave Jones @ 2013-09-05 17:43 UTC (permalink / raw)
To: netdev; +Cc: Neal Cardwell, Yuchung Cheng
Signed-off-by: Dave Jones <davej@fedoraproject.org>
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index b2f6c74..95544e4 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2454,10 +2454,11 @@ static int do_tcp_setsockopt(struct sock *sk, int level,
case TCP_THIN_DUPACK:
if (val < 0 || val > 1)
err = -EINVAL;
- else
+ else {
tp->thin_dupack = val;
if (tp->thin_dupack)
tcp_disable_early_retrans(tp);
+ }
break;
case TCP_REPAIR:
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Add missing braces to do_tcp_setsockopt
2013-09-05 17:43 [PATCH] Add missing braces to do_tcp_setsockopt Dave Jones
@ 2013-09-05 17:55 ` Neal Cardwell
2013-09-05 17:58 ` Dave Jones
0 siblings, 1 reply; 4+ messages in thread
From: Neal Cardwell @ 2013-09-05 17:55 UTC (permalink / raw)
To: Dave Jones; +Cc: Netdev, Yuchung Cheng
On Thu, Sep 5, 2013 at 1:43 PM, Dave Jones <davej@redhat.com> wrote:
> Signed-off-by: Dave Jones <davej@fedoraproject.org>
Acked-by: Neal Cardwell <ncardwell@google.com>
neal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add missing braces to do_tcp_setsockopt
2013-09-05 17:55 ` Neal Cardwell
@ 2013-09-05 17:58 ` Dave Jones
2013-09-05 18:18 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Dave Jones @ 2013-09-05 17:58 UTC (permalink / raw)
To: Neal Cardwell; +Cc: Netdev, Yuchung Cheng
On Thu, Sep 05, 2013 at 01:55:48PM -0400, Neal Cardwell wrote:
> On Thu, Sep 5, 2013 at 1:43 PM, Dave Jones <davej@redhat.com> wrote:
> > Signed-off-by: Dave Jones <davej@fedoraproject.org>
>
> Acked-by: Neal Cardwell <ncardwell@google.com>
>
> neal
Crap, I forgot the
introduced in eed530b6c67624db3f2cf477bac7c4d005d8f7ba ("tcp: early retransmit")
Dave, shall I resend ?
Dave
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add missing braces to do_tcp_setsockopt
2013-09-05 17:58 ` Dave Jones
@ 2013-09-05 18:18 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-09-05 18:18 UTC (permalink / raw)
To: davej; +Cc: ncardwell, netdev, ycheng
From: Dave Jones <davej@redhat.com>
Date: Thu, 5 Sep 2013 13:58:47 -0400
> On Thu, Sep 05, 2013 at 01:55:48PM -0400, Neal Cardwell wrote:
> > On Thu, Sep 5, 2013 at 1:43 PM, Dave Jones <davej@redhat.com> wrote:
> > > Signed-off-by: Dave Jones <davej@fedoraproject.org>
> >
> > Acked-by: Neal Cardwell <ncardwell@google.com>
> >
> > neal
>
> Crap, I forgot the
>
> introduced in eed530b6c67624db3f2cf477bac7c4d005d8f7ba ("tcp: early retransmit")
>
> Dave, shall I resend ?
I'll take care of it.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-05 18:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-05 17:43 [PATCH] Add missing braces to do_tcp_setsockopt Dave Jones
2013-09-05 17:55 ` Neal Cardwell
2013-09-05 17:58 ` Dave Jones
2013-09-05 18:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).