netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bcm63xx_enet: remove deprecated IRQF_DISABLED
@ 2013-09-07  6:56 Michael Opdenacker
  2013-09-11  1:05 ` Jingoo Han
  2013-09-11 20:15 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Opdenacker @ 2013-09-07  6:56 UTC (permalink / raw)
  To: davem
  Cc: jogo, joe, jg1.han, mbizon, netdev, linux-kernel, Michael Opdenacker

This patch proposes to remove the IRQF_DISABLED flag from
drivers/net/ethernet/broadcom/bcm63xx_enet.c

It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index 8ac48fb..b9a5fb6 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -926,13 +926,13 @@ static int bcm_enet_open(struct net_device *dev)
 	if (ret)
 		goto out_phy_disconnect;
 
-	ret = request_irq(priv->irq_rx, bcm_enet_isr_dma, IRQF_DISABLED,
+	ret = request_irq(priv->irq_rx, bcm_enet_isr_dma, 0,
 			  dev->name, dev);
 	if (ret)
 		goto out_freeirq;
 
 	ret = request_irq(priv->irq_tx, bcm_enet_isr_dma,
-			  IRQF_DISABLED, dev->name, dev);
+			  0, dev->name, dev);
 	if (ret)
 		goto out_freeirq_rx;
 
@@ -2156,13 +2156,13 @@ static int bcm_enetsw_open(struct net_device *dev)
 	enet_dmac_writel(priv, 0, ENETDMAC_IRMASK, priv->tx_chan);
 
 	ret = request_irq(priv->irq_rx, bcm_enet_isr_dma,
-			  IRQF_DISABLED, dev->name, dev);
+			  0, dev->name, dev);
 	if (ret)
 		goto out_freeirq;
 
 	if (priv->irq_tx != -1) {
 		ret = request_irq(priv->irq_tx, bcm_enet_isr_dma,
-				  IRQF_DISABLED, dev->name, dev);
+				  0, dev->name, dev);
 		if (ret)
 			goto out_freeirq_rx;
 	}
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] bcm63xx_enet: remove deprecated IRQF_DISABLED
  2013-09-07  6:56 [PATCH] bcm63xx_enet: remove deprecated IRQF_DISABLED Michael Opdenacker
@ 2013-09-11  1:05 ` Jingoo Han
  2013-09-11 20:15 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-09-11  1:05 UTC (permalink / raw)
  To: 'Michael Opdenacker'
  Cc: davem, jogo, joe, mbizon, netdev, linux-kernel

On Saturday, September 07, 2013 3:57 PM, Michael Opdenacker wrote:
> 
> This patch proposes to remove the IRQF_DISABLED flag from
> drivers/net/ethernet/broadcom/bcm63xx_enet.c
> 
> It's a NOOP since 2.6.35 and it will be removed one day.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  drivers/net/ethernet/broadcom/bcm63xx_enet.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] bcm63xx_enet: remove deprecated IRQF_DISABLED
  2013-09-07  6:56 [PATCH] bcm63xx_enet: remove deprecated IRQF_DISABLED Michael Opdenacker
  2013-09-11  1:05 ` Jingoo Han
@ 2013-09-11 20:15 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-09-11 20:15 UTC (permalink / raw)
  To: michael.opdenacker; +Cc: jogo, joe, jg1.han, mbizon, netdev, linux-kernel

From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Date: Sat,  7 Sep 2013 08:56:50 +0200

> This patch proposes to remove the IRQF_DISABLED flag from
> drivers/net/ethernet/broadcom/bcm63xx_enet.c
> 
> It's a NOOP since 2.6.35 and it will be removed one day.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-11 20:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-07  6:56 [PATCH] bcm63xx_enet: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-09-11  1:05 ` Jingoo Han
2013-09-11 20:15 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).