From: Shawn Guo <shawn.guo@linaro.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "fugang.duan@freescale.com" <fugang.duan@freescale.com>,
Hector Palacios <hector.palacios@digi.com>,
Marek Vasut <marex@denx.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"Frank.Li@freescale.com" <Frank.Li@freescale.com>,
"bhutchings@solarflare.com" <bhutchings@solarflare.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: FEC performance degradation with certain packet sizes
Date: Fri, 20 Dec 2013 08:18:59 +0800 [thread overview]
Message-ID: <20131220001858.GD7172@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1387494299.19078.378.camel@edumazet-glaptop2.roam.corp.google.com>
On Thu, Dec 19, 2013 at 03:04:59PM -0800, Eric Dumazet wrote:
> On Thu, 2013-12-19 at 02:44 +0000, fugang.duan@freescale.com wrote:
>
> > Enet IP don't support tso feature.
> >
> > I will reproduce the issue in imx6q/dl sd platform, and analyze the issue.
> > Previous test, we don't use netpipe tool test ethernet performance.
>
> drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c seems broken...
The fec driver running on IMX is drivers/net/ethernet/freescale/fec_main.c
Shawn
>
> If tx_skb_align_workaround() returns NULL, returning NETDEV_TX_BUSY
> is the worst possible thing to do.
>
> Packet should be dropped instead.
>
> Probably not related to your issue.
>
>
next prev parent reply other threads:[~2013-12-20 0:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 12:40 FEC performance degradation on iMX28 with forced link media Hector Palacios
2013-11-24 4:40 ` Marek Vasut
2013-11-25 8:56 ` Hector Palacios
2013-12-18 16:43 ` FEC performance degradation with certain packet sizes Hector Palacios
2013-12-18 17:38 ` Eric Dumazet
2013-12-19 2:44 ` fugang.duan
2013-12-19 23:04 ` Eric Dumazet
2013-12-20 0:18 ` Shawn Guo [this message]
2013-12-20 3:35 ` fugang.duan
2013-12-20 15:01 ` Hector Palacios
2013-12-23 1:08 ` fugang.duan
2013-12-23 2:52 ` fugang.duan
2014-01-21 17:49 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220001858.GD7172@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=Fabio.Estevam@freescale.com \
--cc=Frank.Li@freescale.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fugang.duan@freescale.com \
--cc=hector.palacios@digi.com \
--cc=l.stach@pengutronix.de \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).