From: David Miller <davem@davemloft.net>
To: vyasevich@gmail.com
Cc: wangweidong1@huawei.com, nhorman@tuxdriver.com,
dborkman@redhat.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH net-next 0/7] sctp: remove some macro locking wrappers
Date: Tue, 21 Jan 2014 18:42:29 -0800 (PST) [thread overview]
Message-ID: <20140121.184229.116401257671728929.davem@davemloft.net> (raw)
In-Reply-To: <52DE8F39.30902@gmail.com>
From: Vlad Yasevich <vyasevich@gmail.com>
Date: Tue, 21 Jan 2014 10:16:09 -0500
> On 01/21/2014 02:44 AM, Wang Weidong wrote:
>> In sctp.h we can find some macro locking wrappers. As Neil point out that:
>>
>> "Its because in the origional implementation of the sctp protocol, there was a
>> user space test harness which built the kernel module for userspace execution to
>> cary our some unit testing on the code. It did so by redefining some of those
>> locking macros to user space friendly code. IIRC we haven't use those unit
>> tests in years, and so should be removing them, not adding them to other
>> locations."
>>
>> So I remove them.
>>
>> Wang Weidong (7):
>> sctp: remove macro sctp_spin_[un]lock_irqrestore
>> sctp: remove macro sctp_local_bh_{disable|enable}
>> sctp: remove macro sctp_spin_[un]lock
>> sctp: remove macros sctp_write_[un]_lock
>> sctp: remove macros sctp_read_[un]lock
>> sctp: remove macros sctp_{lock|release}_sock
>> sctp: remove macros sctp_bh_[un]lock_sock
>>
>> include/net/sctp/sctp.h | 27 ++-----------
>> net/sctp/endpointola.c | 4 +-
>> net/sctp/input.c | 54 +++++++++++++-------------
>> net/sctp/proc.c | 12 +++---
>> net/sctp/protocol.c | 4 +-
>> net/sctp/sm_sideeffect.c | 16 ++++----
>> net/sctp/socket.c | 98 ++++++++++++++++++++++++------------------------
>> 7 files changed, 98 insertions(+), 117 deletions(-)
>>
>
> I like this series just the way it is. Very simple to review.
>
> Series
> Acked-by: Vlad Yasevich <vyasevich@gmail.com>
I had to append the DLM fix (since it used the sctp_*() interfaces) to
patch #6, otherwise it would have broken bisection.
Series applied, thanks.
prev parent reply other threads:[~2014-01-22 2:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 7:44 [PATCH net-next 0/7] sctp: remove some macro locking wrappers Wang Weidong
2014-01-21 7:44 ` [PATCH net-next 1/7] sctp: remove macros sctp_spin_[un]lock_irqrestore Wang Weidong
2014-01-21 7:44 ` [PATCH net-next 2/7] sctp: remove macros sctp_local_bh_{disable|enable} Wang Weidong
2014-01-21 7:44 ` [PATCH net-next 3/7] sctp: remove macros sctp_spin_[un]lock Wang Weidong
2014-01-21 7:44 ` [PATCH net-next 4/7] sctp: remove macros sctp_write_[un]_lock Wang Weidong
2014-01-21 7:44 ` [PATCH net-next 5/7] sctp: remove macros sctp_read_[un]lock Wang Weidong
2014-01-21 7:44 ` [PATCH net-next 6/7] sctp: remove macros sctp_{lock|release}_sock Wang Weidong
2014-01-21 7:44 ` [PATCH net-next 7/7] sctp: remove macros sctp_bh_[un]lock_sock Wang Weidong
2014-01-21 14:10 ` [PATCH net-next 0/7] sctp: remove some macro locking wrappers Neil Horman
2014-01-21 15:16 ` Vlad Yasevich
2014-01-22 2:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121.184229.116401257671728929.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
--cc=wangweidong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).