* [PATCH] team: Don't allow team devices to change network namespaces.
@ 2014-01-23 3:07 Chen Weilong
2014-01-23 5:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chen Weilong @ 2014-01-23 3:07 UTC (permalink / raw)
To: jiri, davem; +Cc: netdev
From: Weilong Chen <chenweilong@huawei.com>
Like bonding, team as netdevice doesn't cross netns boundaries.
Team ports and team itself live in same netns.
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
---
drivers/net/team/team.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index dff24e3..2840742 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2034,6 +2034,10 @@ static void team_setup(struct net_device *dev)
dev->features |= NETIF_F_LLTX;
dev->features |= NETIF_F_GRO;
+
+ /* Don't allow team devices to change network namespaces. */
+ dev->features |= NETIF_F_NETNS_LOCAL;
+
dev->hw_features = TEAM_VLAN_FEATURES |
NETIF_F_HW_VLAN_CTAG_TX |
NETIF_F_HW_VLAN_CTAG_RX |
--
1.7.12
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] team: Don't allow team devices to change network namespaces.
2014-01-23 3:07 [PATCH] team: Don't allow team devices to change network namespaces Chen Weilong
@ 2014-01-23 5:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-01-23 5:59 UTC (permalink / raw)
To: chenweilong; +Cc: jiri, netdev
From: Chen Weilong <chenweilong@huawei.com>
Date: Thu, 23 Jan 2014 11:07:22 +0800
> From: Weilong Chen <chenweilong@huawei.com>
>
> Like bonding, team as netdevice doesn't cross netns boundaries.
>
> Team ports and team itself live in same netns.
>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-23 5:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-23 3:07 [PATCH] team: Don't allow team devices to change network namespaces Chen Weilong
2014-01-23 5:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).