* [PATCH] 6lowpan: add a license to 6lowpan_iphc module
@ 2014-01-22 19:25 Yann Droneaud
2014-01-22 22:49 ` Marcel Holtmann
2014-01-23 5:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Yann Droneaud @ 2014-01-22 19:25 UTC (permalink / raw)
To: Alexander Smirnov, Dmitry Eremin-Solenikov, Marcel Holtmann,
Gustavo Padovan, Johan Hedberg, David S. Miller
Cc: Yann Droneaud, linux-zigbee-devel, linux-bluetooth, netdev,
linux-kernel, Jukka Rissanen, Alexander Aring
Since commit 8df8c56a5abc, 6lowpan_iphc is a module of its own.
Unfortunately, it lacks some infrastructure to behave like a
good kernel citizen:
kernel: 6lowpan_iphc: module license 'unspecified' taints kernel.
kernel: Disabling lock debugging due to kernel taint
This patch adds the basic MODULE_LICENSE(); with GPL license:
the code was copied from net/ieee802154/6lowpan.c which is GPL
and the module exports symbol with EXPORT_SYMBOL_GPL();.
Cc: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
---
net/ieee802154/6lowpan_iphc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c
index e14fe8b2c054..860aa2d445ba 100644
--- a/net/ieee802154/6lowpan_iphc.c
+++ b/net/ieee802154/6lowpan_iphc.c
@@ -52,6 +52,7 @@
#include <linux/bitops.h>
#include <linux/if_arp.h>
+#include <linux/module.h>
#include <linux/netdevice.h>
#include <net/ipv6.h>
#include <net/af_ieee802154.h>
@@ -797,3 +798,5 @@ int lowpan_header_compress(struct sk_buff *skb, struct net_device *dev,
return 0;
}
EXPORT_SYMBOL_GPL(lowpan_header_compress);
+
+MODULE_LICENSE("GPL");
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] 6lowpan: add a license to 6lowpan_iphc module
2014-01-22 19:25 [PATCH] 6lowpan: add a license to 6lowpan_iphc module Yann Droneaud
@ 2014-01-22 22:49 ` Marcel Holtmann
2014-01-23 5:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2014-01-22 22:49 UTC (permalink / raw)
To: Yann Droneaud
Cc: Alexander Smirnov, Dmitry Eremin-Solenikov, Gustavo F. Padovan,
Johan Hedberg, David S. Miller, linux-zigbee-devel,
BlueZ development, Network Development, linux-kernel,
Jukka Rissanen, Alexander Aring
Hi Yann,
> Since commit 8df8c56a5abc, 6lowpan_iphc is a module of its own.
>
> Unfortunately, it lacks some infrastructure to behave like a
> good kernel citizen:
>
> kernel: 6lowpan_iphc: module license 'unspecified' taints kernel.
> kernel: Disabling lock debugging due to kernel taint
>
> This patch adds the basic MODULE_LICENSE(); with GPL license:
> the code was copied from net/ieee802154/6lowpan.c which is GPL
> and the module exports symbol with EXPORT_SYMBOL_GPL();.
>
> Cc: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> Cc: Alexander Aring <alex.aring@gmail.com>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> ---
> net/ieee802154/6lowpan_iphc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c
> index e14fe8b2c054..860aa2d445ba 100644
> --- a/net/ieee802154/6lowpan_iphc.c
> +++ b/net/ieee802154/6lowpan_iphc.c
> @@ -52,6 +52,7 @@
>
> #include <linux/bitops.h>
> #include <linux/if_arp.h>
> +#include <linux/module.h>
> #include <linux/netdevice.h>
> #include <net/ipv6.h>
> #include <net/af_ieee802154.h>
> @@ -797,3 +798,5 @@ int lowpan_header_compress(struct sk_buff *skb, struct net_device *dev,
> return 0;
> }
> EXPORT_SYMBOL_GPL(lowpan_header_compress);
> +
> +MODULE_LICENSE("GPL”);
looks good to me.
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] 6lowpan: add a license to 6lowpan_iphc module
2014-01-22 19:25 [PATCH] 6lowpan: add a license to 6lowpan_iphc module Yann Droneaud
2014-01-22 22:49 ` Marcel Holtmann
@ 2014-01-23 5:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-01-23 5:59 UTC (permalink / raw)
To: ydroneaud
Cc: alex.bluesman.smirnov, dbaryshkov, marcel, gustavo,
johan.hedberg, linux-zigbee-devel, linux-bluetooth, netdev,
linux-kernel, jukka.rissanen, alex.aring
From: Yann Droneaud <ydroneaud@opteya.com>
Date: Wed, 22 Jan 2014 20:25:24 +0100
> Since commit 8df8c56a5abc, 6lowpan_iphc is a module of its own.
>
> Unfortunately, it lacks some infrastructure to behave like a
> good kernel citizen:
>
> kernel: 6lowpan_iphc: module license 'unspecified' taints kernel.
> kernel: Disabling lock debugging due to kernel taint
>
> This patch adds the basic MODULE_LICENSE(); with GPL license:
> the code was copied from net/ieee802154/6lowpan.c which is GPL
> and the module exports symbol with EXPORT_SYMBOL_GPL();.
>
> Cc: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> Cc: Alexander Aring <alex.aring@gmail.com>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-23 5:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-22 19:25 [PATCH] 6lowpan: add a license to 6lowpan_iphc module Yann Droneaud
2014-01-22 22:49 ` Marcel Holtmann
2014-01-23 5:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).