* [PATCH v2] ptp: Allow selecting trigger/event index in testptp
@ 2014-02-04 6:25 Stefan Sørensen
2014-02-04 7:20 ` Richard Cochran
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Sørensen @ 2014-02-04 6:25 UTC (permalink / raw)
To: richardcochran, netdev; +Cc: Stefan Sørensen
Currently the trigger/event is hardcoded to 0, this patch adds
a new command line argument -i to select an arbitrary trigger/
event.
Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
---
Changes from v1:
* Keep options sorted
Documentation/ptp/testptp.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
index a74d0a8..a262245 100644
--- a/Documentation/ptp/testptp.c
+++ b/Documentation/ptp/testptp.c
@@ -117,6 +117,7 @@ static void usage(char *progname)
" -f val adjust the ptp clock frequency by 'val' ppb\n"
" -g get the ptp clock time\n"
" -h prints this message\n"
+ " -i val index for event/trigger\n"
" -k val measure the time offset between system and phc clock\n"
" for 'val' times (Maximum 25)\n"
" -p val enable output with a period of 'val' nanoseconds\n"
@@ -161,13 +162,14 @@ int main(int argc, char *argv[])
int perout = -1;
int pps = -1;
int settime = 0;
+ int index = 0;
int64_t t1, t2, tp;
int64_t interval, offset;
progname = strrchr(argv[0], '/');
progname = progname ? 1+progname : argv[0];
- while (EOF != (c = getopt(argc, argv, "a:A:cd:e:f:ghk:p:P:sSt:v"))) {
+ while (EOF != (c = getopt(argc, argv, "a:A:cd:e:f:ghk:p:P:sSt:vi:"))) {
switch (c) {
case 'a':
oneshot = atoi(optarg);
@@ -209,6 +211,9 @@ int main(int argc, char *argv[])
case 't':
adjtime = atoi(optarg);
break;
+ case 'i':
+ index = atoi(optarg);
+ break;
case 'h':
usage(progname);
return 0;
@@ -301,7 +306,7 @@ int main(int argc, char *argv[])
if (extts) {
memset(&extts_request, 0, sizeof(extts_request));
- extts_request.index = 0;
+ extts_request.index = index;
extts_request.flags = PTP_ENABLE_FEATURE;
if (ioctl(fd, PTP_EXTTS_REQUEST, &extts_request)) {
perror("PTP_EXTTS_REQUEST");
@@ -375,7 +380,7 @@ int main(int argc, char *argv[])
return -1;
}
memset(&perout_request, 0, sizeof(perout_request));
- perout_request.index = 0;
+ perout_request.index = index;
perout_request.start.sec = ts.tv_sec + 2;
perout_request.start.nsec = 0;
perout_request.period.sec = 0;
--
1.8.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ptp: Allow selecting trigger/event index in testptp
2014-02-04 6:25 [PATCH v2] ptp: Allow selecting trigger/event index in testptp Stefan Sørensen
@ 2014-02-04 7:20 ` Richard Cochran
0 siblings, 0 replies; 2+ messages in thread
From: Richard Cochran @ 2014-02-04 7:20 UTC (permalink / raw)
To: Stefan Sørensen; +Cc: netdev
Sorry to be so picky, but...
On Tue, Feb 04, 2014 at 07:25:06AM +0100, Stefan Sørensen wrote:
> - while (EOF != (c = getopt(argc, argv, "a:A:cd:e:f:ghk:p:P:sSt:v"))) {
> + while (EOF != (c = getopt(argc, argv, "a:A:cd:e:f:ghk:p:P:sSt:vi:"))) {
how about keeping alphabetical order here
> switch (c) {
> case 'a':
> oneshot = atoi(optarg);
> @@ -209,6 +211,9 @@ int main(int argc, char *argv[])
> case 't':
> adjtime = atoi(optarg);
> break;
> + case 'i':
> + index = atoi(optarg);
> + break;
and here?
> case 'h':
> usage(progname);
> return 0;
[ Yes, the 'h' is out of order.
Pleae fix that, too, if you want to. ]
Thanks,
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-04 7:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-04 6:25 [PATCH v2] ptp: Allow selecting trigger/event index in testptp Stefan Sørensen
2014-02-04 7:20 ` Richard Cochran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).