netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* igb patches needed for stable
@ 2014-04-10 12:36 Thomas Petazzoni
  2014-05-13  7:59 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2014-04-10 12:36 UTC (permalink / raw)
  To: Christoph Paasch, Carolyn Wyborny, Jeff Pieper, Jeff Kirsher
  Cc: netdev, David Miller

Hello,

I just wanted to let you know that the following two patches:

  cb06d102327eadcd1bdc480bfd9f8876251d1007 igb: Fix Null-pointer dereference in igb_reset_q_vector
  b709323d2477614823a38c2f2a9a206e087e28fc igb: Unset IGB_FLAG_HAS_MSIX-flag when falling back to msi-only

should probably be backported to stable 3.14 versions. The above
patches are part of Linus tree, but merged after v3.14 has been
released. However, they fix a regression introduced by cd14ef54d25b
(igb: Change to use statically allocated array for MSIx entries), which
is part of v3.14.

And I'm actually experiencing a crash igb_reset_q_vector() on a system
which has MSI support, but not MSI-X support, and basically the code
path of the driver which fallbacks from MSI-X to MSI is the one
crashing. With both of these patches applied on top of 3.14, my igb NIC
works fine.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: igb patches needed for stable
  2014-04-10 12:36 igb patches needed for stable Thomas Petazzoni
@ 2014-05-13  7:59 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2014-05-13  7:59 UTC (permalink / raw)
  To: Christoph Paasch, Carolyn Wyborny
  Cc: Jeff Pieper, Jeff Kirsher, netdev, David Miller

Hello,

On Thu, 10 Apr 2014 14:36:03 +0200, Thomas Petazzoni wrote:
> Hello,
> 
> I just wanted to let you know that the following two patches:
> 
>   cb06d102327eadcd1bdc480bfd9f8876251d1007 igb: Fix Null-pointer dereference in igb_reset_q_vector
>   b709323d2477614823a38c2f2a9a206e087e28fc igb: Unset IGB_FLAG_HAS_MSIX-flag when falling back to msi-only
> 
> should probably be backported to stable 3.14 versions. The above
> patches are part of Linus tree, but merged after v3.14 has been
> released. However, they fix a regression introduced by cd14ef54d25b
> (igb: Change to use statically allocated array for MSIx entries), which
> is part of v3.14.
> 
> And I'm actually experiencing a crash igb_reset_q_vector() on a system
> which has MSI support, but not MSI-X support, and basically the code
> path of the driver which fallbacks from MSI-X to MSI is the one
> crashing. With both of these patches applied on top of 3.14, my igb NIC
> works fine.

Any news about these patches?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-13  7:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-10 12:36 igb patches needed for stable Thomas Petazzoni
2014-05-13  7:59 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).