[PATCH] of: mdio: fix compile warning in of_mdiobus_register_phy()

[PATCH] of: mdio: fix compile warning in of_mdiobus_register_phy()

[Christian Engelmayer]

Commit de906af1 (net: phy: make of_set_phy_supported work with genphy driver)
removed the last user of variable 'max_speed' in function
of_mdiobus_register_phy(), leading to compile warning "unused variable
‘max_speed’ [-Wunused-variable]". Thus remove it.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
Compile tested. Applies against branch master in tree
git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
---
 drivers/of/of_mdio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index b857094..7c6e277 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -46,7 +46,6 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, struct device_node *chi
 	struct phy_device *phy;
 	bool is_c45;
 	int rc;
-	u32 max_speed = 0;
 	u32 phy_id;
 
 	is_c45 = of_device_is_compatible(child,
-- 
1.9.1

Re: [PATCH] of: mdio: fix compile warning in of_mdiobus_register_phy()

[Florian Fainelli]

2014-05-23 14:33 GMT-07:00 Christian Engelmayer <cengelma@gmx.at>:
> Commit de906af1 (net: phy: make of_set_phy_supported work with genphy driver)
> removed the last user of variable 'max_speed' in function
> of_mdiobus_register_phy(), leading to compile warning "unused variable
> ‘max_speed’ [-Wunused-variable]". Thus remove it.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

> ---
> Compile tested. Applies against branch master in tree
> git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> ---
>  drivers/of/of_mdio.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index b857094..7c6e277 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -46,7 +46,6 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, struct device_node *chi
>         struct phy_device *phy;
>         bool is_c45;
>         int rc;
> -       u32 max_speed = 0;
>         u32 phy_id;
>
>         is_c45 = of_device_is_compatible(child,
> --
> 1.9.1
>



-- 
Florian

Re: [PATCH] of: mdio: fix compile warning in of_mdiobus_register_phy()

[Grant Likely]

On Fri, 23 May 2014 23:33:55 +0200, Christian Engelmayer <cengelma@gmx.at> wrote:
> Commit de906af1 (net: phy: make of_set_phy_supported work with genphy driver)
> removed the last user of variable 'max_speed' in function
> of_mdiobus_register_phy(), leading to compile warning "unused variable
> ‘max_speed’ [-Wunused-variable]". Thus remove it.
> 
> Signed-off-by: Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org>
> ---
> Compile tested. Applies against branch master in tree
> git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Acked-by: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

g.

> ---
>  drivers/of/of_mdio.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index b857094..7c6e277 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -46,7 +46,6 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, struct device_node *chi
>  	struct phy_device *phy;
>  	bool is_c45;
>  	int rc;
> -	u32 max_speed = 0;
>  	u32 phy_id;
>  
>  	is_c45 = of_device_is_compatible(child,
> -- 
> 1.9.1
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html