* [PATCH 1/1] net: tso: Export symbols for modular build
@ 2014-05-26 9:22 Sachin Kamat
2014-05-26 11:15 ` Ezequiel Garcia
2014-05-30 22:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2014-05-26 9:22 UTC (permalink / raw)
To: netdev; +Cc: davem, ezequiel.garcia, sachin.kamat
Export the symbols to fix the below errors when built as modules:
ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
ERROR: "tso_start" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "tso_start" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
net/core/tso.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/core/tso.c b/net/core/tso.c
index 097821dd3a8c..8c3203c585b0 100644
--- a/net/core/tso.c
+++ b/net/core/tso.c
@@ -1,3 +1,4 @@
+#include <linux/export.h>
#include <net/ip.h>
#include <net/tso.h>
@@ -7,6 +8,7 @@ int tso_count_descs(struct sk_buff *skb)
/* The Marvell Way */
return skb_shinfo(skb)->gso_segs * 2 + skb_shinfo(skb)->nr_frags;
}
+EXPORT_SYMBOL(tso_count_descs);
void tso_build_hdr(struct sk_buff *skb, char *hdr, struct tso_t *tso,
int size, bool is_last)
@@ -31,6 +33,7 @@ void tso_build_hdr(struct sk_buff *skb, char *hdr, struct tso_t *tso,
tcph->rst = 0;
}
}
+EXPORT_SYMBOL(tso_build_hdr);
void tso_build_data(struct sk_buff *skb, struct tso_t *tso, int size)
{
@@ -48,6 +51,7 @@ void tso_build_data(struct sk_buff *skb, struct tso_t *tso, int size)
tso->next_frag_idx++;
}
}
+EXPORT_SYMBOL(tso_build_data);
void tso_start(struct sk_buff *skb, struct tso_t *tso)
{
@@ -70,3 +74,4 @@ void tso_start(struct sk_buff *skb, struct tso_t *tso)
tso->next_frag_idx++;
}
}
+EXPORT_SYMBOL(tso_start);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: tso: Export symbols for modular build
2014-05-26 9:22 [PATCH 1/1] net: tso: Export symbols for modular build Sachin Kamat
@ 2014-05-26 11:15 ` Ezequiel Garcia
2014-05-30 22:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ezequiel Garcia @ 2014-05-26 11:15 UTC (permalink / raw)
To: Sachin Kamat; +Cc: netdev, davem
On 26 May 02:52 PM, Sachin Kamat wrote:
> Export the symbols to fix the below errors when built as modules:
> ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_start" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_start" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Thanks for the fix,
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: tso: Export symbols for modular build
2014-05-26 9:22 [PATCH 1/1] net: tso: Export symbols for modular build Sachin Kamat
2014-05-26 11:15 ` Ezequiel Garcia
@ 2014-05-30 22:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-05-30 22:52 UTC (permalink / raw)
To: sachin.kamat; +Cc: netdev, ezequiel.garcia
From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Mon, 26 May 2014 14:52:46 +0530
> Export the symbols to fix the below errors when built as modules:
> ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_start" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_start" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-30 22:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-26 9:22 [PATCH 1/1] net: tso: Export symbols for modular build Sachin Kamat
2014-05-26 11:15 ` Ezequiel Garcia
2014-05-30 22:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).