netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rds/tcp_listen: Replace comma with semicolon
@ 2014-05-30 15:47 Himangi Saraogi
  2014-05-31  0:50 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Himangi Saraogi @ 2014-05-30 15:47 UTC (permalink / raw)
  To: Chien Yen, David S. Miller, rds-devel, netdev, linux-kernel; +Cc: julia.lawall

This patch replaces a comma between expression statements by a semicolon.

A simplified version of the semantic patch that performs this
transformation is as follows:

// <smpl>
@r@
expression e1,e2,e;
type T;
identifier i;
@@

 e1
-,
+;
 e2;
// </smpl>

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
 net/rds/tcp_listen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c
index 4e638f8..23ab4dcd 100644
--- a/net/rds/tcp_listen.c
+++ b/net/rds/tcp_listen.c
@@ -153,7 +153,7 @@ int rds_tcp_listen_init(void)
 	sock->sk->sk_data_ready = rds_tcp_listen_data_ready;
 	write_unlock_bh(&sock->sk->sk_callback_lock);
 
-	sin.sin_family = PF_INET,
+	sin.sin_family = PF_INET;
 	sin.sin_addr.s_addr = (__force u32)htonl(INADDR_ANY);
 	sin.sin_port = (__force u16)htons(RDS_TCP_PORT);
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rds/tcp_listen: Replace comma with semicolon
  2014-05-30 15:47 [PATCH] rds/tcp_listen: Replace comma with semicolon Himangi Saraogi
@ 2014-05-31  0:50 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-31  0:50 UTC (permalink / raw)
  To: himangi774; +Cc: chien.yen, rds-devel, netdev, linux-kernel, julia.lawall

From: Himangi Saraogi <himangi774@gmail.com>
Date: Fri, 30 May 2014 21:17:13 +0530

> This patch replaces a comma between expression statements by a semicolon.
> 
> A simplified version of the semantic patch that performs this
> transformation is as follows:
 ...
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-31  0:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-30 15:47 [PATCH] rds/tcp_listen: Replace comma with semicolon Himangi Saraogi
2014-05-31  0:50 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).