* [PATCH] via-rhine: fix full-duplex with autoneg disable
@ 2014-06-12 10:11 François Cachereul
2014-06-12 17:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: François Cachereul @ 2014-06-12 10:11 UTC (permalink / raw)
To: Roger Luethi; +Cc: f.cachereul, netdev
With some specific configuration (VT6105M on Soekris 5510 and depending
on the device at the other end), fragmented packets were not transmitted
when forcing 100 full-duplex with autoneg disable.
This fix now write full-duplex chips register when forcing full or
half-duplex not only when autoneg is enable.
Signed-off-by: François Cachereul <f.cachereul@alphalink.fr>
---
drivers/net/ethernet/via/via-rhine.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c
index f61dc2b..25bb25b 100644
--- a/drivers/net/ethernet/via/via-rhine.c
+++ b/drivers/net/ethernet/via/via-rhine.c
@@ -1278,8 +1278,9 @@ static void rhine_set_carrier(struct mii_if_info *mii)
/* autoneg is off: Link is always assumed to be up */
if (!netif_carrier_ok(dev))
netif_carrier_on(dev);
- } else /* Let MMI library update carrier status */
- rhine_check_media(dev, 0);
+ }
+
+ rhine_check_media(dev, 0);
netif_info(rp, link, dev, "force_media %d, carrier %d\n",
mii->force_media, netif_carrier_ok(dev));
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] via-rhine: fix full-duplex with autoneg disable
2014-06-12 10:11 [PATCH] via-rhine: fix full-duplex with autoneg disable François Cachereul
@ 2014-06-12 17:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-06-12 17:32 UTC (permalink / raw)
To: f.cachereul; +Cc: rl, netdev
From: François Cachereul <f.cachereul@alphalink.fr>
Date: Thu, 12 Jun 2014 12:11:25 +0200
> With some specific configuration (VT6105M on Soekris 5510 and depending
> on the device at the other end), fragmented packets were not transmitted
> when forcing 100 full-duplex with autoneg disable.
>
> This fix now write full-duplex chips register when forcing full or
> half-duplex not only when autoneg is enable.
>
> Signed-off-by: François Cachereul <f.cachereul@alphalink.fr>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-12 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-12 10:11 [PATCH] via-rhine: fix full-duplex with autoneg disable François Cachereul
2014-06-12 17:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).