* tcp: remove unnecessary tcp_sk assignment.
@ 2014-06-16 20:30 Dave Jones
2014-06-17 4:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2014-06-16 20:30 UTC (permalink / raw)
To: netdev
This variable is overwritten by the child socket assignment before
it ever gets used.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/net/ipv4/tcp_fastopen.c b/net/ipv4/tcp_fastopen.c
index 62e48cf84e60..9771563ab564 100644
--- a/net/ipv4/tcp_fastopen.c
+++ b/net/ipv4/tcp_fastopen.c
@@ -131,7 +131,7 @@ static bool tcp_fastopen_create_child(struct sock *sk,
struct dst_entry *dst,
struct request_sock *req)
{
- struct tcp_sock *tp = tcp_sk(sk);
+ struct tcp_sock *tp;
struct request_sock_queue *queue = &inet_csk(sk)->icsk_accept_queue;
struct sock *child;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: tcp: remove unnecessary tcp_sk assignment.
2014-06-16 20:30 tcp: remove unnecessary tcp_sk assignment Dave Jones
@ 2014-06-17 4:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-06-17 4:35 UTC (permalink / raw)
To: davej; +Cc: netdev
From: Dave Jones <davej@redhat.com>
Date: Mon, 16 Jun 2014 16:30:36 -0400
> This variable is overwritten by the child socket assignment before
> it ever gets used.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
Applied, thanks Dave.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-17 4:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-16 20:30 tcp: remove unnecessary tcp_sk assignment Dave Jones
2014-06-17 4:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).