* [PATCH -next] net: mvpp2: Remove redundant dev_err call in mvpp2_port_probe()
@ 2014-07-20 13:57 weiyj_lk
2014-07-21 5:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: weiyj_lk @ 2014-07-20 13:57 UTC (permalink / raw)
To: Grant Likely, Rob Herring, Ezequiel Garcia, David S. Miller,
Marcin Wojtas
Cc: Wei Yongjun, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/marvell/mvpp2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index 9463ede..d6e997d 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -6062,7 +6062,6 @@ static int mvpp2_port_probe(struct platform_device *pdev,
port->base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(port->base)) {
err = PTR_ERR(port->base);
- dev_err(&pdev->dev, "cannot obtain port base address\n");
goto err_free_irq;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: mvpp2: Remove redundant dev_err call in mvpp2_port_probe()
2014-07-20 13:57 [PATCH -next] net: mvpp2: Remove redundant dev_err call in mvpp2_port_probe() weiyj_lk
@ 2014-07-21 5:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-21 5:27 UTC (permalink / raw)
To: weiyj_lk; +Cc: grant.likely, robh+dt, ezequiel.garcia, mw, yongjun_wei, netdev
From: weiyj_lk@163.com
Date: Sun, 20 Jul 2014 21:57:17 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-21 5:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-20 13:57 [PATCH -next] net: mvpp2: Remove redundant dev_err call in mvpp2_port_probe() weiyj_lk
2014-07-21 5:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).