* [PATCH 13/14] fec_mpc52xx: delete unneeded test before of_node_put
@ 2014-08-08 10:07 Julia Lawall
2014-08-08 17:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2014-08-08 10:07 UTC (permalink / raw)
To: netdev; +Cc: kernel-janitors, linux-kernel, Uwe Kleine-König
From: Julia Lawall <Julia.Lawall@lip6.fr>
Of_node_put supports NULL as its argument, so the initial test is not
necessary.
Suggested by Uwe Kleine-König.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
-if (e)
of_node_put(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/freescale/fec_mpc52xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx.c b/drivers/net/ethernet/freescale/fec_mpc52xx.c
index 9947765..ff55fbb 100644
--- a/drivers/net/ethernet/freescale/fec_mpc52xx.c
+++ b/drivers/net/ethernet/freescale/fec_mpc52xx.c
@@ -1015,8 +1015,7 @@ mpc52xx_fec_remove(struct platform_device *op)
unregister_netdev(ndev);
- if (priv->phy_node)
- of_node_put(priv->phy_node);
+ of_node_put(priv->phy_node);
priv->phy_node = NULL;
irq_dispose_mapping(ndev->irq);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 13/14] fec_mpc52xx: delete unneeded test before of_node_put
2014-08-08 10:07 [PATCH 13/14] fec_mpc52xx: delete unneeded test before of_node_put Julia Lawall
@ 2014-08-08 17:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-08-08 17:28 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux-kernel, u.kleine-koenig
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Fri, 8 Aug 2014 12:07:54 +0200
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Of_node_put supports NULL as its argument, so the initial test is not
> necessary.
>
> Suggested by Uwe Kleine-König.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-08 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-08 10:07 [PATCH 13/14] fec_mpc52xx: delete unneeded test before of_node_put Julia Lawall
2014-08-08 17:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).