From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: eric.dumazet@gmail.com, heiko.carstens@de.ibm.com,
sasha.levin@oracle.com, paulmck@linux.vnet.ibm.com,
nikolay@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, braunu@de.ibm.com
Subject: Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies
Date: Sat, 11 Oct 2014 19:08:29 -0400 (EDT) [thread overview]
Message-ID: <20141011.190829.876705206204533685.davem@davemloft.net> (raw)
In-Reply-To: <20141011222514.GA14186@casper.infradead.org>
From: Thomas Graf <tgraf@suug.ch>
Date: Sat, 11 Oct 2014 23:25:14 +0100
> I think the issue here is obvious and a fix is on the way to move
> the insertion and removal to a worker to no longer require the
> synchronize_rcu().
>
> What bothers me is that the synchronize_rcu() should only occur
> on expand/shrink and not for every table update. The default table
> size is 64.
Not true, every netlink socket release incurs a synchronize_net()
now, because we added such a call to netlink_release().
I specifically brought this up to as a possible problem when the
changes went in...
next prev parent reply other threads:[~2014-10-11 23:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 8:36 [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies Heiko Carstens
2014-10-11 19:32 ` Eric Dumazet
2014-10-11 22:25 ` Thomas Graf
2014-10-11 23:08 ` David Miller [this message]
2014-10-20 8:21 ` Heiko Carstens
2014-10-20 19:53 ` [PATCH] netlink: Re-add locking to netlink_lookup() and seq walker Thomas Graf
2014-10-21 7:04 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141011.190829.876705206204533685.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=braunu@de.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sasha.levin@oracle.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).