From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, rasesh.mody@qlogic.com
Subject: Re: [PATCH net] bna: fix skb->truesize underestimation
Date: Fri, 17 Oct 2014 23:56:58 -0400 (EDT) [thread overview]
Message-ID: <20141017.235658.809511246236814038.davem@davemloft.net> (raw)
In-Reply-To: <1413575155.27176.5.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 17 Oct 2014 12:45:55 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> skb->truesize is not meant to be tracking amount of used bytes
> in an skb, but amount of reserved/consumed bytes in memory.
>
> For instance, if we use a single byte in last page fragment,
> we have to account the full size of the fragment.
>
> skb->truesize can be very different from skb->len, that has
> a very specific safety purpose.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2014-10-18 3:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 19:45 [PATCH net] bna: fix skb->truesize underestimation Eric Dumazet
2014-10-18 3:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017.235658.809511246236814038.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rasesh.mody@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).