[PATCH net] bna: fix skb->truesize underestimation

[PATCH net] bna: fix skb->truesize underestimation

[Eric Dumazet]

From: Eric Dumazet <edumazet@google.com>

skb->truesize is not meant to be tracking amount of used bytes
in an skb, but amount of reserved/consumed bytes in memory.

For instance, if we use a single byte in last page fragment,
we have to account the full size of the fragment.

skb->truesize can be very different from skb->len, that has
a very specific safety purpose.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Rasesh Mody <rasesh.mody@qlogic.com>
---
 drivers/net/ethernet/brocade/bna/bnad.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
index 153cafac323c..c3861de9dc81 100644
--- a/drivers/net/ethernet/brocade/bna/bnad.c
+++ b/drivers/net/ethernet/brocade/bna/bnad.c
@@ -552,6 +552,7 @@ bnad_cq_setup_skb_frags(struct bna_rcb *rcb, struct sk_buff *skb,
 
 		len = (vec == nvecs) ?
 			last_fraglen : unmap->vector.len;
+		skb->truesize += unmap->vector.len;
 		totlen += len;
 
 		skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
@@ -563,7 +564,6 @@ bnad_cq_setup_skb_frags(struct bna_rcb *rcb, struct sk_buff *skb,
 
 	skb->len += totlen;
 	skb->data_len += totlen;
-	skb->truesize += totlen;
 }
 
 static inline void

Re: [PATCH net] bna: fix skb->truesize underestimation

[David Miller]

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 17 Oct 2014 12:45:55 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> skb->truesize is not meant to be tracking amount of used bytes
> in an skb, but amount of reserved/consumed bytes in memory.
> 
> For instance, if we use a single byte in last page fragment,
> we have to account the full size of the fragment.
> 
> skb->truesize can be very different from skb->len, that has
> a very specific safety purpose.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied.