From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: cwang@twopensource.com, roy.qing.li@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] vxlan: remove the dead codes
Date: Sat, 18 Oct 2014 11:20:44 +0200 [thread overview]
Message-ID: <20141018112044.77939a2e@uryu.home.lan> (raw)
In-Reply-To: <20141017.162449.747433271390481594.davem@davemloft.net>
On Fri, 17 Oct 2014 16:24:49 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Cong Wang <cwang@twopensource.com>
> Date: Fri, 17 Oct 2014 10:33:08 -0700
>
> > On Thu, Oct 16, 2014 at 11:04 PM, <roy.qing.li@gmail.com> wrote:
> >> From: Li RongQing <roy.qing.li@gmail.com>
> >>
> >> remove the dead codes, no user uses vxlan_salt
> >>
> >> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> >> ---
> >> drivers/net/vxlan.c | 4 ----
> >> 1 file changed, 4 deletions(-)
> >>
> >> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> >> index 77ab844..855a81d 100644
> >> --- a/drivers/net/vxlan.c
> >> +++ b/drivers/net/vxlan.c
> >> @@ -152,8 +152,6 @@ struct vxlan_dev {
> >> struct hlist_head fdb_head[FDB_HASH_SIZE];
> >> };
> >>
> >> -/* salt for hash table */
> >> -static u32 vxlan_salt __read_mostly;
> >
> > Hmm, it has never been used since it was born. Maybe we should
> > really use for vxlan hash table?
>
> Yes, agreed, and I am very sure that this was Stephen Hemminger's
> original intention.
yes. never did rekeying, and it would have been hard.
prev parent reply other threads:[~2014-10-18 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 6:04 [PATCH v2] vxlan: remove the dead codes roy.qing.li
2014-10-17 17:33 ` Cong Wang
2014-10-17 20:24 ` David Miller
2014-10-18 9:20 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141018112044.77939a2e@uryu.home.lan \
--to=stephen@networkplumber.org \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).