[PATCH v2] vxlan: remove the dead codes

[PATCH v2] vxlan: remove the dead codes

[roy.qing.li]

From: Li RongQing <roy.qing.li@gmail.com>

remove the dead codes, no user uses vxlan_salt

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
 drivers/net/vxlan.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 77ab844..855a81d 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -152,8 +152,6 @@ struct vxlan_dev {
 	struct hlist_head fdb_head[FDB_HASH_SIZE];
 };
 
-/* salt for hash table */
-static u32 vxlan_salt __read_mostly;
 static struct workqueue_struct *vxlan_wq;
 
 static void vxlan_sock_work(struct work_struct *work);
@@ -2797,8 +2795,6 @@ static int __init vxlan_init_module(void)
 	if (!vxlan_wq)
 		return -ENOMEM;
 
-	get_random_bytes(&vxlan_salt, sizeof(vxlan_salt));
-
 	rc = register_pernet_subsys(&vxlan_net_ops);
 	if (rc)
 		goto out1;
-- 
1.7.10.4

Re: [PATCH v2] vxlan: remove the dead codes

[Cong Wang]

On Thu, Oct 16, 2014 at 11:04 PM,  <roy.qing.li@gmail.com> wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
>
> remove the dead codes, no user uses vxlan_salt
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> ---
>  drivers/net/vxlan.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 77ab844..855a81d 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -152,8 +152,6 @@ struct vxlan_dev {
>         struct hlist_head fdb_head[FDB_HASH_SIZE];
>  };
>
> -/* salt for hash table */
> -static u32 vxlan_salt __read_mostly;

Hmm, it has never been used since it was born. Maybe we should
really use for vxlan hash table?

Re: [PATCH v2] vxlan: remove the dead codes

[David Miller]

From: Cong Wang <cwang@twopensource.com>
Date: Fri, 17 Oct 2014 10:33:08 -0700

> On Thu, Oct 16, 2014 at 11:04 PM,  <roy.qing.li@gmail.com> wrote:
>> From: Li RongQing <roy.qing.li@gmail.com>
>>
>> remove the dead codes, no user uses vxlan_salt
>>
>> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
>> ---
>>  drivers/net/vxlan.c |    4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
>> index 77ab844..855a81d 100644
>> --- a/drivers/net/vxlan.c
>> +++ b/drivers/net/vxlan.c
>> @@ -152,8 +152,6 @@ struct vxlan_dev {
>>         struct hlist_head fdb_head[FDB_HASH_SIZE];
>>  };
>>
>> -/* salt for hash table */
>> -static u32 vxlan_salt __read_mostly;
> 
> Hmm, it has never been used since it was born. Maybe we should
> really use for vxlan hash table?

Yes, agreed, and I am very sure that this was Stephen Hemminger's
original intention.

Re: [PATCH v2] vxlan: remove the dead codes

[Stephen Hemminger]

On Fri, 17 Oct 2014 16:24:49 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:

> From: Cong Wang <cwang@twopensource.com>
> Date: Fri, 17 Oct 2014 10:33:08 -0700
> 
> > On Thu, Oct 16, 2014 at 11:04 PM,  <roy.qing.li@gmail.com> wrote:
> >> From: Li RongQing <roy.qing.li@gmail.com>
> >>
> >> remove the dead codes, no user uses vxlan_salt
> >>
> >> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> >> ---
> >>  drivers/net/vxlan.c |    4 ----
> >>  1 file changed, 4 deletions(-)
> >>
> >> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> >> index 77ab844..855a81d 100644
> >> --- a/drivers/net/vxlan.c
> >> +++ b/drivers/net/vxlan.c
> >> @@ -152,8 +152,6 @@ struct vxlan_dev {
> >>         struct hlist_head fdb_head[FDB_HASH_SIZE];
> >>  };
> >>
> >> -/* salt for hash table */
> >> -static u32 vxlan_salt __read_mostly;
> > 
> > Hmm, it has never been used since it was born. Maybe we should
> > really use for vxlan hash table?
> 
> Yes, agreed, and I am very sure that this was Stephen Hemminger's
> original intention.

yes. never did rekeying, and it would have been hard.