* [PATCH] net: typhoon: Remove redundant casts
@ 2014-10-21 14:51 Rasmus Villemoes
2014-10-21 21:29 ` David Dillow
2014-10-24 4:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Rasmus Villemoes @ 2014-10-21 14:51 UTC (permalink / raw)
To: David Dillow; +Cc: netdev, linux-kernel, Rasmus Villemoes
Both image_data and typhoon_fw->data are const u8*, so the cast to u8*
is unnecessary and confusing.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/net/ethernet/3com/typhoon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c
index 48775b8..dede43f 100644
--- a/drivers/net/ethernet/3com/typhoon.c
+++ b/drivers/net/ethernet/3com/typhoon.c
@@ -1285,7 +1285,7 @@ typhoon_request_firmware(struct typhoon *tp)
return err;
}
- image_data = (u8 *) typhoon_fw->data;
+ image_data = typhoon_fw->data;
remaining = typhoon_fw->size;
if (remaining < sizeof(struct typhoon_file_header))
goto invalid_fw;
@@ -1343,7 +1343,7 @@ typhoon_download_firmware(struct typhoon *tp)
int i;
int err;
- image_data = (u8 *) typhoon_fw->data;
+ image_data = typhoon_fw->data;
fHdr = (struct typhoon_file_header *) image_data;
/* Cannot just map the firmware image using pci_map_single() as
--
2.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: typhoon: Remove redundant casts
2014-10-21 14:51 [PATCH] net: typhoon: Remove redundant casts Rasmus Villemoes
@ 2014-10-21 21:29 ` David Dillow
2014-10-24 4:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Dillow @ 2014-10-21 21:29 UTC (permalink / raw)
To: Rasmus Villemoes; +Cc: netdev, linux-kernel
On Tue, 2014-10-21 at 16:51 +0200, Rasmus Villemoes wrote:
> Both image_data and typhoon_fw->data are const u8*, so the cast to u8*
> is unnecessary and confusing.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: David Dillow <dave@thedillows.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: typhoon: Remove redundant casts
2014-10-21 14:51 [PATCH] net: typhoon: Remove redundant casts Rasmus Villemoes
2014-10-21 21:29 ` David Dillow
@ 2014-10-24 4:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-10-24 4:41 UTC (permalink / raw)
To: linux; +Cc: dave, netdev, linux-kernel
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Date: Tue, 21 Oct 2014 16:51:43 +0200
> Both image_data and typhoon_fw->data are const u8*, so the cast to u8*
> is unnecessary and confusing.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-24 4:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-21 14:51 [PATCH] net: typhoon: Remove redundant casts Rasmus Villemoes
2014-10-21 21:29 ` David Dillow
2014-10-24 4:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).