* [PATCH net-next 1/3] tcp: Correction to RFC number in comment
@ 2014-10-29 19:27 Sowmini Varadhan
2014-10-30 16:32 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Sowmini Varadhan @ 2014-10-29 19:27 UTC (permalink / raw)
To: davem, sowmini.varadhan; +Cc: netdev
Challenge ACK is described in RFC 5961, fix typo.
Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
---
net/ipv4/tcp_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index a12b455..d285962 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -5028,7 +5028,7 @@ static bool tcp_validate_incoming(struct sock *sk, struct sk_buff *skb,
/* step 3: check security and precedence [ignored] */
/* step 4: Check for a SYN
- * RFC 5691 4.2 : Send a challenge ack
+ * RFC 5961 4.2 : Send a challenge ack
*/
if (th->syn) {
syn_challenge:
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/3] tcp: Correction to RFC number in comment
2014-10-29 19:27 [PATCH net-next 1/3] tcp: Correction to RFC number in comment Sowmini Varadhan
@ 2014-10-30 16:32 ` David Miller
2014-10-30 16:51 ` Sowmini Varadhan
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-10-30 16:32 UTC (permalink / raw)
To: sowmini.varadhan; +Cc: netdev
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Wed, 29 Oct 2014 15:27:29 -0400
> Challenge ACK is described in RFC 5961, fix typo.
>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
This TCP change has nothing to do with your sunvnet driver changes.
Please do not ever mix unrelated changes like this within a series.
Submit the TCP change on it's own, and then respin the sunvnet
driver specific patches separately.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/3] tcp: Correction to RFC number in comment
2014-10-30 16:32 ` David Miller
@ 2014-10-30 16:51 ` Sowmini Varadhan
0 siblings, 0 replies; 3+ messages in thread
From: Sowmini Varadhan @ 2014-10-30 16:51 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On (10/30/14 12:32), David Miller wrote:
>
> Please do not ever mix unrelated changes like this within a series.
>
> Submit the TCP change on it's own, and then respin the sunvnet
> driver specific patches separately.
Done.
fwiw, I ran into this comment when debugging something in sunvnet,
and was quite confused by the rfc 5691 reference :-)
--Sowmini
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-30 16:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-29 19:27 [PATCH net-next 1/3] tcp: Correction to RFC number in comment Sowmini Varadhan
2014-10-30 16:32 ` David Miller
2014-10-30 16:51 ` Sowmini Varadhan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).