* [PATCH net-next] Driver: Vmxnet3: Change the hex constant to its decimal equivalent
@ 2015-02-06 21:48 Shrikrishna Khare
2015-02-09 0:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Shrikrishna Khare @ 2015-02-06 21:48 UTC (permalink / raw)
To: sbhatewara, pv-drivers, netdev, linux-kernel; +Cc: Shrikrishna Khare
The hex constant chosen for VMXNET3_REV1_MAGIC is offensive,
replace it with its decimal equivalent.
Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
Reviewed-by: Shreyas Bhatewara <sbhatewara@vmware.com>
---
drivers/net/vmxnet3/vmxnet3_defs.h | 2 +-
drivers/net/vmxnet3/vmxnet3_int.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h
index 25b6fa4..3718d02 100644
--- a/drivers/net/vmxnet3/vmxnet3_defs.h
+++ b/drivers/net/vmxnet3/vmxnet3_defs.h
@@ -393,7 +393,7 @@ struct Vmxnet3_DriverInfo {
};
-#define VMXNET3_REV1_MAGIC 0xbabefee1
+#define VMXNET3_REV1_MAGIC 3133079265u
/*
* QueueDescPA must be 128 bytes aligned. It points to an array of
diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
index 406144b..cd71c77 100644
--- a/drivers/net/vmxnet3/vmxnet3_int.h
+++ b/drivers/net/vmxnet3/vmxnet3_int.h
@@ -69,10 +69,10 @@
/*
* Version numbers
*/
-#define VMXNET3_DRIVER_VERSION_STRING "1.3.3.0-k"
+#define VMXNET3_DRIVER_VERSION_STRING "1.3.4.0-k"
/* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */
-#define VMXNET3_DRIVER_VERSION_NUM 0x01030300
+#define VMXNET3_DRIVER_VERSION_NUM 0x01030400
#if defined(CONFIG_PCI_MSI)
/* RSS only makes sense if MSI-X is supported. */
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] Driver: Vmxnet3: Change the hex constant to its decimal equivalent
2015-02-06 21:48 [PATCH net-next] Driver: Vmxnet3: Change the hex constant to its decimal equivalent Shrikrishna Khare
@ 2015-02-09 0:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-02-09 0:55 UTC (permalink / raw)
To: skhare; +Cc: sbhatewara, pv-drivers, netdev, linux-kernel
From: Shrikrishna Khare <skhare@vmware.com>
Date: Fri, 6 Feb 2015 13:48:28 -0800
> The hex constant chosen for VMXNET3_REV1_MAGIC is offensive,
> replace it with its decimal equivalent.
>
> Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
> Reviewed-by: Shreyas Bhatewara <sbhatewara@vmware.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-09 0:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-06 21:48 [PATCH net-next] Driver: Vmxnet3: Change the hex constant to its decimal equivalent Shrikrishna Khare
2015-02-09 0:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).