From: David Miller <davem@redhat.com>
To: f.fainelli@gmail.com
Cc: andrew@lunn.ch, netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: Remove redundant phy_attach()
Date: Mon, 09 Feb 2015 14:06:05 -0800 (PST) [thread overview]
Message-ID: <20150209.140605.383021111937070414.davem@redhat.com> (raw)
In-Reply-To: <54D908B6.9020101@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 09 Feb 2015 11:21:26 -0800
> On 08/02/15 17:29, Andrew Lunn wrote:
>> dsa_slave_phy_setup() finds the phy for the port via device tree and
>> using of_phy_connect(), or it uses the fall back of taking a phy from
>> the switch internal mdio bus and calling phy_connect_direct(). Either
>> way, if a phy is found, phy_attach_direct() is called to attach the
>> phy to the slave device.
>>
>> In dsa_slave_create(), a second call to phy_attach() is made. This
>> results in the warning "PHY already attached". Remove this second,
>> redundant attaching of the phy.
>>
>> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2015-02-09 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 1:29 [PATCH] net: dsa: Remove redundant phy_attach() Andrew Lunn
2015-02-09 19:21 ` Florian Fainelli
2015-02-09 22:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209.140605.383021111937070414.davem@redhat.com \
--to=davem@redhat.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).