From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: Remove redundant phy_attach()
Date: Mon, 09 Feb 2015 11:21:26 -0800 [thread overview]
Message-ID: <54D908B6.9020101@gmail.com> (raw)
In-Reply-To: <1423445395-412-1-git-send-email-andrew@lunn.ch>
On 08/02/15 17:29, Andrew Lunn wrote:
> dsa_slave_phy_setup() finds the phy for the port via device tree and
> using of_phy_connect(), or it uses the fall back of taking a phy from
> the switch internal mdio bus and calling phy_connect_direct(). Either
> way, if a phy is found, phy_attach_direct() is called to attach the
> phy to the slave device.
>
> In dsa_slave_create(), a second call to phy_attach() is made. This
> results in the warning "PHY already attached". Remove this second,
> redundant attaching of the phy.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> net/dsa/slave.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 589aafd01fc5..d104ae15836f 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -676,18 +676,5 @@ dsa_slave_create(struct dsa_switch *ds, struct device *parent,
>
> netif_carrier_off(slave_dev);
>
> - if (p->phy != NULL) {
> - if (ds->drv->get_phy_flags)
> - p->phy->dev_flags |= ds->drv->get_phy_flags(ds, port);
> -
> - phy_attach(slave_dev, dev_name(&p->phy->dev),
> - PHY_INTERFACE_MODE_GMII);
> -
> - p->phy->autoneg = AUTONEG_ENABLE;
> - p->phy->speed = 0;
> - p->phy->duplex = 0;
> - p->phy->advertising = p->phy->supported | ADVERTISED_Autoneg;
> - }
> -
> return slave_dev;
> }
>
--
Florian
next prev parent reply other threads:[~2015-02-09 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 1:29 [PATCH] net: dsa: Remove redundant phy_attach() Andrew Lunn
2015-02-09 19:21 ` Florian Fainelli [this message]
2015-02-09 22:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D908B6.9020101@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).