From: David Miller <davem@davemloft.net>
To: kys@microsoft.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
jasowang@redhat.com
Subject: Re: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()
Date: Mon, 27 Apr 2015 22:57:09 -0400 (EDT) [thread overview]
Message-ID: <20150427.225709.1737864122610182544.davem@davemloft.net> (raw)
In-Reply-To: <1430183690-24198-1-git-send-email-kys@microsoft.com>
From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: Mon, 27 Apr 2015 18:14:50 -0700
> Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory
> allocation in the packet send path. This commit introduced a bug since it
> did not account for the case if the skb was cloned. Fix this bug by
> using the pre-reserved head room only if the skb is not cloned.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
We have generic infrastructure to do this, please try instead:
err = skb_cow_head(skb, pkt_sz);
this will take care of everything for you and you can get rid
of all of this dynamic memory allocation etc. in this code
path.
next prev parent reply other threads:[~2015-04-28 2:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 1:14 [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit() K. Y. Srinivasan
2015-04-28 2:57 ` David Miller [this message]
2015-04-28 3:23 ` KY Srinivasan
2015-04-28 2:57 ` Dexuan Cui
2015-04-28 18:27 ` Sergei Shtylyov
2015-04-28 18:59 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427.225709.1737864122610182544.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).