From: KY Srinivasan <kys@microsoft.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>
Subject: RE: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()
Date: Tue, 28 Apr 2015 18:59:55 +0000 [thread overview]
Message-ID: <BY2PR0301MB0711A65F2833086181B0AC4FA0E80@BY2PR0301MB0711.namprd03.prod.outlook.com> (raw)
In-Reply-To: <553FD0FC.3090704@cogentembedded.com>
> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> Sent: Tuesday, April 28, 2015 11:27 AM
> To: KY Srinivasan; davem@davemloft.net; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com
> Subject: Re: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()
>
> Hello.
>
> On 04/28/2015 04:14 AM, K. Y. Srinivasan wrote:
>
> > Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated
> memory
>
> One "commit" is enough. :-)
> And please also specify that commit's summary in parens.
>
> > allocation in the packet send path. This commit introduced a bug since it
> > did not account for the case if the skb was cloned. Fix this bug by
> > using the pre-reserved head room only if the skb is not cloned.
>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>
> [...]
>
> WBR, Sergei
Will do; thanks.
K. Y
prev parent reply other threads:[~2015-04-28 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 1:14 [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit() K. Y. Srinivasan
2015-04-28 2:57 ` David Miller
2015-04-28 3:23 ` KY Srinivasan
2015-04-28 2:57 ` Dexuan Cui
2015-04-28 18:27 ` Sergei Shtylyov
2015-04-28 18:59 ` KY Srinivasan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY2PR0301MB0711A65F2833086181B0AC4FA0E80@BY2PR0301MB0711.namprd03.prod.outlook.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).