From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@qlogic.com
Cc: mschmidt@redhat.com, netdev@vger.kernel.org,
Dmitry.Kravkov@qlogic.com, Ariel.Elior@qlogic.com
Subject: Re: [PATCH net] bnx2x: really disable TPA if 'disable_tpa' option is set
Date: Mon, 27 Apr 2015 23:14:21 -0400 (EDT) [thread overview]
Message-ID: <20150427.231421.1640743940845631891.davem@davemloft.net> (raw)
In-Reply-To: <B5657A6538887040AD3A81F1008BEC63D2041C@AVMB1.qlogic.org>
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Mon, 27 Apr 2015 18:15:44 +0000
>>> bnx2x's 'disable_tpa=1' module option is not respected properly and TPA
>>> (transparent packet aggregation) remains enabled. Even though the
>>> module option causes LRO to be disabled, TPA is enabled in GRO mode.
>>>
>>> Additionally, disabling GRO via ethtool then has no effect. One can
>>> still observe tpa_* statistics increase and large packets being received
>>> in tcpdump.
>>>
>>> The bug was an unintended consequence of commit aebf6244cd39 "bnx2x: Be
>>> more forgiving toward SW GRO".
>>>
>>> Fix it by following the bp->disable_tpa flag when initializing fp's.
>>>
>>> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
>>
>>Applied, thanks.
>
> Michal - thanks, but Dave -is it possible you gave us only 2.5 hours to
> review this one?
You'll need to send me a revert or changes relative to this one as
the commit is not only permanent when it reaches my tree, it's also
made it's way into Linus's tree now as well.
next prev parent reply other threads:[~2015-04-28 3:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 15:20 [PATCH net] bnx2x: really disable TPA if 'disable_tpa' option is set Michal Schmidt
2015-04-27 17:43 ` David Miller
2015-04-27 18:15 ` Yuval Mintz
2015-04-28 3:14 ` David Miller [this message]
2015-04-28 9:05 ` Michal Schmidt
2015-04-28 9:11 ` Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427.231421.1640743940845631891.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@qlogic.com \
--cc=Dmitry.Kravkov@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).